fix(web): fix construction for suggestions emitted after left-deleting whitespace 🚂 - #16307
Merged
jahorton merged 3 commits intoAug 6, 2026
Merged
Conversation
…g whitespace Build-bot: skip release:web release:android
User Test ResultsTest specification and instructions Test Artifacts |
Contributor
Test Specs
Test Results
|
ermshiperete
approved these changes
Aug 6, 2026
Comment on lines
+1284
to
+1286
| // Erasing a single-char whitespace requires deletion of two tokens, the | ||
| // last of which is empty. Check for this case and handle it accordingly | ||
| // as well. |
Contributor
There was a problem hiding this comment.
I don't understand this comment. Does it explain the if (!penultimateTransform) ? In that case it would be better if it would come before the break; line. Or does it refer to the next if?
jahorton
enabled auto-merge
August 6, 2026 18:58
jahorton
disabled auto-merge
August 6, 2026 18:58
jahorton
enabled auto-merge
August 6, 2026 18:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds unit tests to cover the most substantially affected method. That method also had its parameter tweaked to better reflect the data it actually needs, which simplifies what must be provided for unit tests.
Build-bot: skip release:web release:android
User Testing
Use Keyman for Android for the following user tests.
TEST_ROBUSTNESS: Spend at least 5 minutes trying to "break" predictive text and/or cause it to work improperly while using
sil_euro_latinandgff_amharic. Report back on any issues discovered.TEST_REPRO_1: Attempt to reproduce the error-case reported in a user test on #16223:
TEST_REPRO_2: Attempt to reproduce the error-case reported in a user test on #16223 (using
gff_amharic):