refactor(web): improve naming of _SetTargetDir function - #16311
Merged
Conversation
`_SetTargetDir` deals with setting the text direction of the target, not the target directory. This change mainly renames the private function to `setTargetTextDirection`. Build-bot: skip build:web Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
mcdurdin
approved these changes
Aug 10, 2026
Comment on lines
+31
to
+33
| if (!elem) { | ||
| return; | ||
| } |
Member
There was a problem hiding this comment.
I know this change is not a change in behaviour. Looking more broadly, ideally this private function shouldn't really be silently no-oping on invalid inputs. We should, at least in a debug build, be throwing. This is a bigger issue through all the KMW code...
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.263-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_SetTargetDirdeals with setting the text direction of the target, not the target directory. This change mainly renames the private function tosetTargetTextDirection.Build-bot: skip build:web
Test-bot: skip