feat(developer): support output folder and --continue-on-error - #16453
Merged
Conversation
Add support for specifying an output folder instead of filename for the `--out-file` parameter of kmc. This allows for batch builds, which can be much faster than invoking kmc for each file separately. Alongside that, add a `--continue-on-error` parameter that allows for batch builds to continue even if a single file fails to build. (Note that if a fatal error is encountered, kmc aborts with exit code 70).
ermshiperete
approved these changes
Aug 31, 2026
ermshiperete
requested changes
Aug 31, 2026
Contributor
|
@mcdurdin, the Developer Test Build is empty. Could you rebuilt this again? |
Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
Member
Author
Running now |
ermshiperete
approved these changes
Sep 1, 2026
Contributor
Test Specs
Test Results
|
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.278-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for specifying an output folder instead of filename for the
--out-fileparameter of kmc. This allows for batch builds, which can be much faster than invoking kmc for each file separately.Alongside that, add a
--continue-on-errorparameter that allows for batch builds to continue even if a single file fails to build. (Note that if a fatal error is encountered, kmc aborts with exit code 70).Fixes: #16447
User Testing
kmc build <files...> -o target_folder. Verify that the files are written intotarget_folderas expected.kmc build <files...> -o target_folder/. Verify that the files are written intotarget_folderas expected.target_file. attempt to build multiple files by specifying them on the command line withkmc build <files...> -o target_file. Verify that kmc exits with an error.kmc build <files...> --continue-on-error. At least one file should have a build error. Verify that kmc attempts to build all files (so, put the failing files before good files in the list!).kmc build <files...>. At least one file should have a build error. Verify that kmc stops on the first file with an error.