feat: app_deployment collection and CM-006 evaluation#4
Merged
Conversation
Define app_deployment JSON shape per design doc §13 and extract repository short names from Git remote URLs for join with code_change. Co-authored-by: Cursor <cursoragent@cursor.com>
Add providers.argocd, evidence.app_deployment scope, CM-006 controls, and helpers for server normalization and daily skip detection. Co-authored-by: Cursor <cursoragent@cursor.com>
Extend storage backend with app_deployment_evidence upsert and date/repo filtering for postgres and filesystem backends. Co-authored-by: Cursor <cursoragent@cursor.com>
Extract evaluateTraceabilityCore for join through approvals, add CM-006 with CI URL terminal check, and wire app_deployment into evaluate runner. Co-authored-by: Cursor <cursoragent@cursor.com>
Reuse shared join/author/approvals logic for infra_deployment and keep execution.url as the CM-007 inline terminal check. Co-authored-by: Cursor <cursoragent@cursor.com>
… collection Collect deployment history via ApplicationService.Get, map status.history to evidence, and pin argoproj/argo-cd/v2 for API compatibility. Co-authored-by: Cursor <cursoragent@cursor.com>
Expose kao collect app-deployment, run it as step 3 in kao run daily before infra_deployment, and skip when Argo CD is not configured. Co-authored-by: Cursor <cursoragent@cursor.com>
Add sample matrix-style app deployment evidence for files-mode evaluate and verify filesystem Put/Query for app_deployment. Co-authored-by: Cursor <cursoragent@cursor.com>
Align daily and explicit collect with optional infra evidence: Terraform-less orgs need not configure apply_workflows. Update design doc §7/§8 accordingly. Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
追記: infra_deployment の optional collect
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Argo CD の本番 Application デプロイ証跡（
app_deployment）の収集と CM-006 評価を追加する。これで 4 種類すべての証跡の収集・評価をサポートする。AppDeployment型、providers.argocd、evidence.app_deployment（scope.applications必須）、controls.app_deployment.traceabilityPutAppDeployment/QueryAppDeployment（postgres + filesystem）repository+revisionで過去code_changeを結合（lookback_days、最新merged_at優先）kao collect app-deployment— 公式argoproj/argo-cd/v2apiclient でstatus.historyを収集ci.runs[].url）evaluateTraceabilityCoreを共有、terminal は各 evaluator で inlineapp_deployment/infra_deploymentは設定がある場合のみ collect（Argo CD や Terraform apply 未設定の組織ではスキップ）。設計 doc §7/§8 を更新Commit 順（実装手順）
feat: add AppDeployment evidence type and git URL repository helperfeat: add app_deployment evidence, argocd provider, and control configfeat: add app_deployment storage Put and Queryfeat: implement CM-006 app_deployment evaluation using traceability corerefactor: migrate CM-007 to evaluateTraceabilityCorefeat: add argocd provider using official apiclient for app_deployment collectionfeat: add collect app-deployment command and daily steptest: add app_deployment fixture data and storage round-trip testfeat: skip infra_deployment collect when not configuredTest plan
go test ./...kao collect app-deployment --config kao.yaml --date YYYY-MM-DD（実 Argo CD 環境、ARGOCD_SERVER/ARGOCD_TOKEN要）kao evaluate --config kao.local.yaml --input files --app-deployment testdata/app_deployment.jsonl --code-change testdata/code_change.jsonlkao run daily --config kao.yaml --date YYYY-MM-DDMade with Cursor