Closed
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 37ded0d:
|
Contributor
Member
|
@kennedybaird if you wanted to add your GitHub pull request review to things (as a LGTM or a reject), we could probably merge things quicker 🚀 |
Contributor
|
As mentioned by @kennedybaird — those + others have been covered in I covered this in #9272 Gonna close this one but thank you for your intent to help out 🙏 |
Member
Author
|
Thanks @kennedybaird @simonswiss @dcousens 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a typo in the Heroku deployment doc.
I noticed a few broken links while reading the doc. I fixed one and added a TODO for the other. It might be good for someone to follow up on that one since I’m not sure what the correct link should be.