Skip to content

Fixed Typo in Docs URL#9271

Closed
solrik wants to merge 1 commit intokeystonejs:mainfrom
solrik:main
Closed

Fixed Typo in Docs URL#9271
solrik wants to merge 1 commit intokeystonejs:mainfrom
solrik:main

Conversation

@solrik
Copy link

@solrik solrik commented Aug 8, 2024

This PR fixes a typo in the Heroku deployment doc.

I noticed a few broken links while reading the doc. I fixed one and added a TODO for the other. It might be good for someone to follow up on that one since I’m not sure what the correct link should be.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 8, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 37ded0d:

Sandbox Source
@keystone-6/sandbox Configuration

@solrik solrik changed the title Fixed URL typo Fixed Typo in Docs URL Aug 8, 2024
@kennedybaird
Copy link
Contributor

I covered this in #9272 @solrik - didn't realise you had worked on this earlier today

@dcousens dcousens requested a review from simonswiss August 9, 2024 00:18
@dcousens
Copy link
Member

dcousens commented Aug 9, 2024

@kennedybaird if you wanted to add your GitHub pull request review to things (as a LGTM or a reject), we could probably merge things quicker 🚀

@simonswiss
Copy link
Contributor

As mentioned by @kennedybaird — those + others have been covered in I covered this in #9272

Gonna close this one but thank you for your intent to help out 🙏

@simonswiss simonswiss closed this Aug 9, 2024
@dcousens
Copy link
Member

dcousens commented Aug 9, 2024

Thanks for your first contribution @solrik, your patch is really appreciated despite not being accepted! #9272 simply covered the problem holistically. 💙

@solrik
Copy link
Author

solrik commented Aug 9, 2024

Thanks @kennedybaird @simonswiss @dcousens 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants