fix(menu): localize file menu items - #74
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Localize the macOS File menu title and Close Window item in
MainMenu.swiftby routing them through the existingL10n.MainMenuaccessors.This also adds the corresponding
main_menu.fileandmain_menu.close_windowentries to each existingLocalizable.stringslocale so the synthesized localization API stays complete.Tests
tuist generatexcodebuild test -project Keyty.xcodeproj -scheme Keyty -destination 'platform=macOS'xcodebuild build -project Keyty.xcodeproj -scheme Keyty -configuration DebugRun project commands from
Apps/Keyty.UI Changes
N/A
Documentation
Release Notes
Localized the File menu title and Close Window menu item in the macOS app menu.