Skip to content

Comments

Clang-based C parser#593

Merged
h0nzZik merged 134 commits intokframework:masterfrom
h0nzZik:clang-c-parser
Nov 7, 2019
Merged

Clang-based C parser#593
h0nzZik merged 134 commits intokframework:masterfrom
h0nzZik:clang-c-parser

Conversation

@h0nzZik
Copy link
Contributor

@h0nzZik h0nzZik commented Oct 31, 2019

Also includes #577.

Copy link
Member

@dwightguth dwightguth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems okay to me. I didn't really look in detail at the specifics of the parser or at the semantics code though, so someone else should still review the semantic changes. (@mickyabir or @ehildenb probably).

I assume you have gone over the list of failing tests and ensured that none of them are due to bugs in your code?

@h0nzZik h0nzZik merged commit d61025b into kframework:master Nov 7, 2019
@h0nzZik
Copy link
Contributor Author

h0nzZik commented Nov 7, 2019

Oh sorry, I did not notice the comment and merged it. @mickyabir @ehildenb Guys, can you look at the semantics changes?
@dwightguth ./offsetof-1.c was failing in Clang, but after Chris fixed the test, it is failing in this PR because it was not implemented in the Clang-based parser. I have already implemented it locally, but it is now failing due to the problem with OffsetOfNode::getArrayExprIndex that I mentioned on slack. I hope to enable that test in the next PR.

h0nzZik added a commit to h0nzZik/c-semantics that referenced this pull request Jan 9, 2020
h0nzZik added a commit that referenced this pull request Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants