ci(root): add biome lint enforcement, clean up test suppressions#71
Merged
Conversation
Lint rules were never enforced in CI, allowing warnings to accumulate on main. Add a strict `lint` job running `biome check . --error-on-warnings`. Make the tree pass by removing dead `configDir` field in ThemeManager (written but never read), and disable noNonNullAssertion for all test files via biome override (fixtures with known-present properties are standard test idiom). Remove now-orphaned per-line biome-ignore comments. Also group GITHUB_OUTPUT writes in build matrix step for clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lint was never enforced in CI, so warnings accumulated silently on
main(70 at last count). This adds a strictlintjob to the build workflow (biome check . --error-on-warnings— ANY diagnostic fails) and makes the tree pass it:configDirfield in hub'sThemeManager(written in the constructor, never read)style/noNonNullAssertionfor**/*.spec.tsvia a biome override — non-null assertions on known-present fixtures are standard test idiom; the rule stays active for production codebiome-ignoresuppression comments that the override made orphaned (an unused suppression is itself a diagnostic under the strict gate)GITHUB_OUTPUTwrites in the build-matrix step (shellcheck style)Test plan
biome check . --error-on-warningsexits 0 (was: 70 warnings)pnpm -r typecheckgreen;actionlintclean on build.ymlLintjob running and green