Skip to content

Support tracing in play ReactiveMongoDaoBase via Kamon#798

Merged
Evergreen-person merged 1 commit into
mainfrom
797-support-tracing-for-play-reactivemongo
Jan 14, 2025
Merged

Support tracing in play ReactiveMongoDaoBase via Kamon#798
Evergreen-person merged 1 commit into
mainfrom
797-support-tracing-for-play-reactivemongo

Conversation

@Evergreen-person

@Evergreen-person Evergreen-person commented Dec 13, 2024

Copy link
Copy Markdown
Collaborator
  • Add for all operations;
  • Make tracing enableable;

@Evergreen-person Evergreen-person linked an issue Dec 13, 2024 that may be closed by this pull request
@Evergreen-person
Evergreen-person force-pushed the 797-support-tracing-for-play-reactivemongo branch from 336f998 to bb9b2b4 Compare December 13, 2024 06:21
@codecov

codecov Bot commented Dec 13, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 61.76471% with 13 lines in your changes missing coverage. Please review.

Project coverage is 53.16%. Comparing base (143c525) to head (b6d7b63).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...s/play/reactivemongo/ReactiveMongoOperations.scala 0.00% 8 Missing ⚠️
...i/MongoConnectionSendExpectingResponseAdvice.scala 82.60% 4 Missing ⚠️
...tils/play/reactivemongo/ReactiveMongoDaoBase.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #798      +/-   ##
==========================================
+ Coverage   51.25%   53.16%   +1.91%     
==========================================
  Files         114      115       +1     
  Lines        1319     1311       -8     
  Branches       81       86       +5     
==========================================
+ Hits          676      697      +21     
+ Misses        643      614      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Evergreen-person
Evergreen-person force-pushed the 797-support-tracing-for-play-reactivemongo branch 2 times, most recently from e6f9523 to afa1635 Compare December 19, 2024 07:34
@Evergreen-person
Evergreen-person force-pushed the 797-support-tracing-for-play-reactivemongo branch 4 times, most recently from 648c2f5 to e2cd5f3 Compare December 23, 2024 09:33
@Evergreen-person
Evergreen-person marked this pull request as ready for review December 23, 2024 09:47
@Evergreen-person
Evergreen-person force-pushed the 797-support-tracing-for-play-reactivemongo branch 2 times, most recently from 701e9d6 to 0d6e363 Compare December 24, 2024 13:08
@Evergreen-person
Evergreen-person marked this pull request as draft January 4, 2025 08:58
@Evergreen-person
Evergreen-person force-pushed the 797-support-tracing-for-play-reactivemongo branch 4 times, most recently from 8a6357f to e573f3a Compare January 5, 2025 09:08
@Evergreen-person
Evergreen-person marked this pull request as ready for review January 9, 2025 08:59
@Evergreen-person
Evergreen-person force-pushed the 797-support-tracing-for-play-reactivemongo branch 3 times, most recently from df5e7b6 to 0630c76 Compare January 13, 2025 11:32
@kazievab kazievab added the feature New feature or request label Jan 14, 2025
@Evergreen-person
Evergreen-person force-pushed the 797-support-tracing-for-play-reactivemongo branch from 0630c76 to b6d7b63 Compare January 14, 2025 07:18
@Evergreen-person
Evergreen-person merged commit c087072 into main Jan 14, 2025
@Evergreen-person
Evergreen-person deleted the 797-support-tracing-for-play-reactivemongo branch January 14, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support tracing for play reactivemongo

3 participants