fix: prevent memory/CPU leaks in importer and nzbfilesystem - #143
Merged
Conversation
- Replace fire-and-forget goroutines in updateFileHealthOnError with synchronous operations using a 5-second timeout context to prevent unbounded goroutine accumulation when reading corrupted files - Wrap segment reader operations in parser.go with closure and defer to ensure cleanup happens regardless of how the loop exits - Add channel draining in NzbDav import defer block to prevent parser goroutine from blocking indefinitely when import is cancelled 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
updateFileHealthOnErrorwith synchronous operations using a 5-second timeout context to prevent unbounded goroutine accumulation when reading corrupted filesparser.gowith closure and defer to ensure cleanup happens regardless of how the loop exitsTest plan
🤖 Generated with Claude Code