refactor: standardize API responses and add shared utilities - #174
Merged
Conversation
This is a comprehensive refactoring that introduces: ## Phase 1: Shared Utilities - Add shared errors package (`internal/errors`) with NonRetryableError - Add HTTP client factory (`internal/httpclient`) with preset timeouts - Add config accessor methods (`internal/config/accessors.go`) - Simplify DeepCopy using jinzhu/copier (235 lines → 15 lines) ## Phase 2: API Standardization - Create unified response builders (`internal/api/response.go`) - Migrate all handlers to use response builders: - queue_handlers.go - health_handlers.go - config_handlers.go - auth_handlers.go - Apply admin middleware to protected routes - SABnzbd handlers intentionally unchanged (API compatibility) ## Benefits - Consistent JSON response format across all endpoints - DRY error handling with standard error codes - Reduced code duplication - Centralized HTTP client configuration - Improved maintainability 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
go build ./...- builds successfullygo test ./...- all tests pass🤖 Generated with Claude Code