fix(usenet): resolve send on closed channel panic in UsenetReader - #307
Merged
Conversation
Race condition between Close() and Read()/Start(): Close() would close the init channel while Read() could concurrently send on it via initDownload.Do(), causing a panic. Remove close(b.init) from Close() and add ctx.Done() case to downloadManager's initial select so it exits via context cancellation instead of relying on channel closure. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Close()andRead()/Start()inUsenetReaderthat causedpanic: send on closed channelclose(b.init)fromClose()— context cancellation handles shutdown insteadcase <-ctx.Done()todownloadManager()'s initialselectfor clean exit on context cancellationTest plan
go build ./internal/usenet/compiles without errorsgo test ./internal/usenet/passes all testssend on closed channelpanics under concurrent file reads🤖 Generated with Claude Code