fix(health): reset stuck pending jobs on startup and add disable toggle - #335
Merged
Conversation
- Add ResetStalePendingFiles() to reset pending files where retry_count >= max_retries back to retry_count=0; these were silently excluded from health cycles forever - Call ResetStalePendingFiles() during worker Start() alongside the existing ResetFileAllChecking() call - Add GetHealthEnabled() config accessor (Health.Enabled field already exists in HealthConfig struct) - Check GetHealthEnabled() at the start of Start() - if disabled, log a warning and return nil without starting the worker Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
yoshitaka420
pushed a commit
to yoshitaka420/altmount
that referenced
this pull request
Jun 1, 2026
…le (kipsilabs#335) - Add ResetStalePendingFiles() to reset pending files where retry_count >= max_retries back to retry_count=0; these were silently excluded from health cycles forever - Call ResetStalePendingFiles() during worker Start() alongside the existing ResetFileAllChecking() call - Add GetHealthEnabled() config accessor (Health.Enabled field already exists in HealthConfig struct) - Check GetHealthEnabled() at the start of Start() - if disabled, log a warning and return nil without starting the worker Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pendingwithretry_count >= max_retrieswere silently excluded from theGetUnhealthyFiles()query and never re-checked. A newResetStalePendingFiles()call during worker startup resets their retry count so they get picked up in the next cycle.health.enabled: falsein config. TheHealth.Enabledfield already existed in the config struct but was never checked —GetHealthEnabled()is now checked at the start ofStart().Test plan
health.enabled: falsein config → restart → verify worker does not start (log: "Health worker is disabled via configuration")health.enabled: trueor omit → verify worker starts normally🤖 Generated with Claude Code