fix(frontend): resolve sidebar always showing 0.0.0 version - #365
Merged
Conversation
- Add execSync-based git fallbacks in vite.config.ts so dev builds automatically pick up the real version and commit hash without needing env vars pre-set - Update build-frontend Makefile target to pass APP_VERSION and GIT_COMMIT explicitly, keeping frontend and Go binary in sync Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
yoshitaka420
pushed a commit
to yoshitaka420/altmount
that referenced
this pull request
Jun 1, 2026
…s#365) - Add execSync-based git fallbacks in vite.config.ts so dev builds automatically pick up the real version and commit hash without needing env vars pre-set - Update build-frontend Makefile target to pass APP_VERSION and GIT_COMMIT explicitly, keeping frontend and Go binary in sync Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
frontend/vite.config.ts: AddedgetAppVersion()andgetGitCommit()helpers that use Node'sexecSyncas fallback whenAPP_VERSION/GIT_COMMITenv vars are not set. Duringbun run dev, the sidebar now shows the actual git-derived version and commit hash instead of0.0.0/unknown.Makefilebuild-frontend: ResolvesVERSIONandCOMMITviagit describe/git rev-parsebefore the build and passes them asAPP_VERSION/GIT_COMMIT, matching the values used bybuild-cli's ldflags.Test plan
cd frontend && bun run dev— sidebar should show git-derived version (e.g.v1.2.3-5-gabcdef) and commit hashmake build-frontend— values should match Go binary ldflagsgit describe --alwaysstill returns a commit hash; sidebar degrades gracefully"0.0.0"/"unknown"🤖 Generated with Claude Code