feat(providers): add skip_ping support and upgrade nntppool to v4.5.0 - #388
Merged
Conversation
Bumps nntppool from v4.4.1 to v4.5.0 which introduces the SkipPing field on Provider. Exposes the option end-to-end so users with servers that don't support the DATE NNTP command can bypass the startup ping check. - go.mod/go.sum: upgrade nntppool v4 to v4.5.0 - internal/config: add SkipPing to ProviderConfig, map it in ToNNTPProvider(), and include it in providersFieldsEqual() so a config change triggers a pool reload - frontend/types: add skip_ping to ProviderConfig, ProviderFormData, ProviderUpdateRequest, and ProviderCreateRequest - frontend/ProviderModal: add "Skip server ping" checkbox with helper text in the Options & Security section - docs: add "Date Error When Adding a Provider" troubleshooting section Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
yoshitaka420
pushed a commit
to yoshitaka420/altmount
that referenced
this pull request
Jun 1, 2026
…kipsilabs#388) Bumps nntppool from v4.4.1 to v4.5.0 which introduces the SkipPing field on Provider. Exposes the option end-to-end so users with servers that don't support the DATE NNTP command can bypass the startup ping check. - go.mod/go.sum: upgrade nntppool v4 to v4.5.0 - internal/config: add SkipPing to ProviderConfig, map it in ToNNTPProvider(), and include it in providersFieldsEqual() so a config change triggers a pool reload - frontend/types: add skip_ping to ProviderConfig, ProviderFormData, ProviderUpdateRequest, and ProviderCreateRequest - frontend/ProviderModal: add "Skip server ping" checkbox with helper text in the Options & Security section - docs: add "Date Error When Adding a Provider" troubleshooting section Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SkipPingfield onProviderskip_pingend-to-end (backend config, frontend types, provider modal UI)Changes
Backend
go.mod/go.sum: bumpgithub.com/javi11/nntppool/v4to v4.5.0internal/config/manager.go: addSkipPing booltoProviderConfig, map it inToNNTPProvider(), and include it inprovidersFieldsEqual()so toggling the flag triggers a pool reloadFrontend
src/types/config.ts: addskip_pingtoProviderConfig,ProviderFormData,ProviderUpdateRequest, andProviderCreateRequestsrc/components/config/ProviderModal.tsx: add Skip server ping checkbox in the Options & Security section with descriptive helper text; initialized from existing provider in edit modeDocs
docs/docs/5. Troubleshooting/common-issues.md: new "Date Error When Adding a Provider" section explaining theDATEping issue and how to resolve it via YAML or UITest plan
skip_ping: truein config — pool starts without DATE ping errorsgo build ./...passesbun run check && bun run buildpasses🤖 Generated with Claude Code