fix(importer): merge all PAR2 index files and group RAR archives by base name - #406
Merged
Merged
Conversation
…ase name Read all small PAR2 index files (≤5 segments) and merge their descriptors instead of picking the single smallest file. Releases with multiple PAR2 sets (e.g. main archive + sample) previously returned only the sample's 1-entry map, leaving 46+ archive files unmatched and unrenaming. Deduplicates by Hash16k so identical descriptors across set files are not duplicated. Also groups RAR archive files by base name before passing to AnalyzeRarContentFromNzb, so NZBs containing multiple separate RAR archives (e.g. main + sample) are analysed independently rather than mixing their parts together. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
yoshitaka420
pushed a commit
to yoshitaka420/altmount
that referenced
this pull request
Jun 1, 2026
…ase name (kipsilabs#406) Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetFileDescriptorsnow reads all small PAR2 index files (≤5 segments) and merges their descriptors byHash16k, instead of picking the single smallest file. Releases with multiple PAR2 sets (e.g. main archive + sample) previously returned only the sample's 1-entry map, leaving 46+ archive files with obfuscated names unmatched.ProcessArchivenow groups RAR files by base name before callingAnalyzeRarContentFromNzb, so NZBs containing multiple separate RAR archives (main + sample) are analysed independently rather than mixing their parts.GroupArchivesByBaseNameextracted toaggregator.go(exported, tested) andextractRarBaseNameadded toutils.go.Test plan
go test ./internal/importer/archive/rar/...— newTestGroupArchivesByBaseNamepassesgo test ./internal/importer/...— all existing tests pass🤖 Generated with Claude Code