Skip to content

refactor: clean up internal/api dead code and migrate to response builders - #436

Merged
javi11 merged 1 commit into
mainfrom
cleanup/api-dead-code-response-builders
Mar 22, 2026
Merged

refactor: clean up internal/api dead code and migrate to response builders#436
javi11 merged 1 commit into
mainfrom
cleanup/api-dead-code-response-builders

Conversation

@javi11

@javi11 javi11 commented Mar 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Remove unused dead code from errors.go: ErrMsg* constants, APIErrorResponse type, NewAPIError, and NewAPIErrorResponse
  • Delete responses_http.go entirely (5 legacy net/http response helpers never called anywhere)
  • Remove legacy net/http parser functions (ParsePagination, ParseTimeParam) from parsers.go
  • Migrate all inline c.JSON(fiber.Map{...}) responses in health_library_sync_handlers.go and rclone_handlers.go to established Respond* builder pattern

Test plan

  • go build ./... passes
  • go vet ./internal/api/... passes
  • go test ./internal/api/... passes
  • Verify library sync endpoints return correct response format (start, cancel, status, dry-run, needed)
  • Verify rclone endpoints return correct response format (mount status, start, stop, test config, test connection, clear cache)

🤖 Generated with Claude Code

…lders

Remove unused legacy code (ErrMsg constants, APIErrorResponse type,
net/http response helpers, net/http parser functions) and migrate
inline JSON responses in library sync and rclone handlers to the
established Respond* builder pattern for consistency.
@javi11
javi11 merged commit 1b4de95 into main Mar 22, 2026
2 checks passed
@javi11
javi11 deleted the cleanup/api-dead-code-response-builders branch March 22, 2026 16:06
yoshitaka420 pushed a commit to yoshitaka420/altmount that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant