fix: make hanwen FUSE Handle.Read() context-aware - #438
Merged
Conversation
… forever FUSE reads could block indefinitely when NNTP servers hang, prefetch throttles deadlock, or pool connections are exhausted. Unlike WebDAV (which escapes via HTTP request context), the hanwen FUSE Handle.Read() called file.Seek/Read directly with no context checking. Add readWithContext() and seekWithContext() helpers that wrap blocking I/O in goroutines with context select, mirroring the proven readFullContext pattern from MetadataVirtualFile.ReadAt(). On context cancellation, returns EINTR; orphaned goroutines complete when Handle.Release() calls file.Close().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
readWithContext()andseekWithContext()helpers that wrap blocking I/O in goroutines with context select, returningEINTRon cancellationreadFullContextpattern already used inMetadataVirtualFile.ReadAt()Test plan
go test ./internal/fuse/backend/hanwen/... -race -v— all 10 tests pass (3 new)go vet ./internal/fuse/...— no issuesgo build ./...— builds cleanly🤖 Generated with Claude Code