feat: preserve internal folder structure when extracting RAR/7zip archives - #449
Merged
Merged
Conversation
…hives Previously, files extracted from RAR and 7zip archives were placed flat into the virtual directory, discarding any subdirectories present inside the archive. Now the internal path structure is preserved so that e.g. Extras/bonus.mkv inside an archive lands at <virtualDir>/Extras/bonus.mkv. ISO-expanded files and single-file NZBs with rename-to-NZB-name are exempt and continue to be placed flat, as their filenames are synthetic. Adds table-driven tests for both RAR and 7zip aggregators covering flat files, subdirectory preservation, multi-file subdirs, rename flattening, and Windows-style backslash path normalisation.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
yoshitaka420
pushed a commit
to yoshitaka420/altmount
that referenced
this pull request
Jun 1, 2026
…hives (kipsilabs#449) Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extras/bonus.mkvinside an archive lands at<virtualDir>/Extras/bonus.mkvrename_to_nzb_nameremain flat (their filenames are synthetic, subdirs don't apply)Test plan
go test ./internal/importer/archive/rar/... ./internal/importer/archive/sevenzip/...— all existing and new tests passTestProcessArchivePreservesInternalFolderStructurecovers: flat files, subdir preservation, multiple files in same subdir, rename-flattening exception, and backslash normalisation