Potential fix for code scanning alert no. 21: Workflow does not contain permissions #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds minimal permissions blocks to several GitHub Actions workflows to satisfy a code-scanning alert and consolidates outdated publish workflows.
- Introduces a unified
publish.ymlwith root-level and job-levelpermissionsforcontentsandpackages. - Adds
permissions: contents: readto thenpm-ci.ymlworkflow. - Removes the obsolete
real-npm-publish.ymlandgithub-npm-publish.ymlworkflows.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/publish.yml | New combined publish workflow with minimal permissions |
| .github/workflows/npm-ci.yml | Added permissions: contents: read block to existing CI job |
| .github/workflows/real-npm-publish.yml | Removed outdated npm publish workflow |
| .github/workflows/github-npm-publish.yml | Removed outdated GitHub Packages publish workflow |
Comments suppressed due to low confidence (3)
.github/workflows/publish.yml:1
- The comment says this workflow will run tests, but the test step is commented out. Update the description to reflect actual steps or re-enable the test job.
# This workflow will run tests using node and then publish a package to GitHub Packages when a release is created
.github/workflows/publish.yml:4
- [nitpick] The workflow name is quite generic; consider renaming it (e.g., "Publish Packages to GitHub & npm") to clarify its purpose.
name: Node.js Package
.github/workflows/publish.yml:54
- [nitpick] This step is duplicated in multiple jobs; consider extracting it into a reusable composite action or define a job that both publish jobs can depend on.
- run: cp README.md packages/stencil-library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/kit-data-manager/pid-component/security/code-scanning/21
To fix the issue, we need to add a
permissionsblock to the workflow. Since the workflow only performs basic CI tasks (installing dependencies and running builds), it requires minimal permissions. Thecontents: readpermission is sufficient for these operations. Thepermissionsblock should be added at the root level of the workflow to apply to all jobs.Suggested fixes powered by Copilot Autofix. Review carefully before merging.