refactor(fs): replace process-wide os.Chdir with explicit base path - #1273
Open
ManthanNimodiya wants to merge 1 commit into
Open
refactor(fs): replace process-wide os.Chdir with explicit base path#1273ManthanNimodiya wants to merge 1 commit into
ManthanNimodiya wants to merge 1 commit into
Conversation
Fixes kitops-ml#1269 Signed-off-by: ManthanNimodiya <manthannimodiya989898@gmail.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses #1269 by eliminating process-wide
os.Chdircalls inpack,unpack, andkitimportoperations in favor of explicit base paths.Changing the process working directory via
os.Chdirmutated the caller's working directory and prevented safe concurrent execution.Key Changes
ContextDirtoSaveModelOptionsin local-storage.go; updated tar and raw layer writers to resolve and walk paths relativeto
contextDir. Removedos.Chdirfrompkg/cmd/pack/cmd.goandpkg/cmd/kitimport/util.go.os.ChdirfromUnpackModelKitandunpackRemotein core.go. Layers are now explicitly extracted and verified intotarget unpack destinations.
TestPackUnpack_PreservesWorkingDirin pack-unpack_test.go verifying that neitherkit packnorkit unpackalters the processworking directory.
Testing
go test ./pkg/...passedgo test ./...passed (including all integration tests intesting/)Fixes #1269