Skip to content

fix(MP-2947): pair Almost Funded with lending stats in Keep your impact going#7054

Merged
roger-in-kiva merged 1 commit into
mainfrom
MP-2947_almost_funded_next_steps_fix
Jul 13, 2026
Merged

fix(MP-2947): pair Almost Funded with lending stats in Keep your impact going#7054
roger-in-kiva merged 1 commit into
mainfrom
MP-2947_almost_funded_next_steps_fix

Conversation

@roger-in-kiva

Copy link
Copy Markdown
Collaborator

Summary

The "Keep your impact going" section on the MyKiva Next Steps page previously
rendered either the Almost Funded next step or the 2-tile lending-stats card
(MyKivaRegionExperience) — never both — via an internal v-if/v-else keyed on
post-lending status. As a result, the Almost Funded card never appeared next to the
lending stats for post-lending lenders, which QA flagged.

This PR gates the section on !showRegionExperienceInFirstRow (post-lending lenders and
superlenders) and renders both cards together: Almost Funded at its natural
single-column width, followed by the lending-stats card spanning the remaining two of the
three columns.

Context

  • QA repro (post-lending lender): lend → return to MyKiva → open Next Steps → the Almost
    Funded card did not appear next to the lending stats in "Keep your impact going".
  • Root cause: <AlmostFundedNextStep v-if="!showPostLendingNextStepsCards" /> evaluated to
    false for post-lending lenders, so they only ever saw the region card.

What changed

src/pages/MyKiva/MyKivaNextStepsContent.vue

  • Section gate: v-if="!showPostLendingNextStepsCards || !userLentToAllRegions"
    v-if="!showRegionExperienceInFirstRow".
  • Removed the internal v-if/v-else so both AlmostFundedNextStep and
    MyKivaRegionExperience (md:tw-col-span-2) render together.
  • Refreshed the explanatory comment to match the new behavior.

Related links

Testing

Related specs (test/unit/specs/pages/MyKiva/MyKivaNextStepsContent.spec.js):

  • shows both Almost Funded and the region card in "Keep your impact going" for post-lending lenders — asserts both render, Almost Funded at natural width (no md:tw-col-span-2/3), region card spans two columns.
  • hides "Keep your impact going" but keeps the row-1 region card for non-post-lending lenders

Unaffected but relevant: test/unit/specs/components/MyKiva/AlmostFundedNextStep.spec.js (the card component itself is unchanged).

Verification:

  • npm run unit280 files, 4194 passed / 6 skipped
  • npm run lint0 errors

Screenshots

Screenshot 2026-07-13 at 10 55 00 a m

…ct going

The "Keep your impact going" section previously rendered either the Almost
Funded next step OR the 2-tile lending stats card (MyKivaRegionExperience),
never both, via an internal v-if/v-else keyed on post-lending status. As a
result the Almost Funded card never appeared next to the lending stats for
post-lending lenders, which QA flagged on the Next Steps page.

Gate the section on !showRegionExperienceInFirstRow (i.e. post-lending lenders
and superlenders) and render both cards together: Almost Funded at its natural
single-column width, followed by the lending stats card spanning the remaining
two of the three columns. Because the gate is the exact negation of the row-1
region-card condition, MyKivaRegionExperience still renders in exactly one
place — row 1 when it belongs there, otherwise paired with Almost Funded below.

- MyKivaNextStepsContent.vue: update the section v-if, drop the internal
  v-if/v-else so both cards render, and refresh the explanatory comment.
- MyKivaNextStepsContent.spec.js: rewrite the affected specs to the new
  behavior, covering post-lending, non-post-lending, and superlender cases.
@roger-in-kiva
roger-in-kiva requested a review from a team July 13, 2026 17:35
@roger-in-kiva roger-in-kiva added the b2c Sends B2C team a message in Slack on PR creation label Jul 13, 2026
@roger-in-kiva
roger-in-kiva merged commit dd84819 into main Jul 13, 2026
7 checks passed
@roger-in-kiva
roger-in-kiva deleted the MP-2947_almost_funded_next_steps_fix branch July 13, 2026 17:43
kiva-robot added a commit that referenced this pull request Jul 14, 2026
## [3.77.0-rc.1](v3.76.0...v3.77.0-rc.1) (2026-07-14)

### 🎉 New Features

* add new helper to retrieve goal in review information and test query timing ([5c93e00](5c93e00))
* borrower profile migration AD-1 ([#7044](#7044)) ([8647a8d](8647a8d))
* implement migrated withdraw-beta pages ([#7043](#7043)) ([45bef37](45bef37))
* **MP-2947:** roll out Almost Funded next step, remove lending stat experiment ([#7042](#7042)) ([9667beb](9667beb))
* **MP-3036:** add AI loan pills to the goal recommended-loan card ([#7056](#7056)) ([bec1b6f](bec1b6f))
* roll out AI loan pills across My Kiva, Checkout, and borrower profile ([#7051](#7051)) ([94fbc2d](94fbc2d))

### 🐛 Bugfixes

* add goal summary monolith query ([d382045](d382045))
* beta page fixes ([#7057](#7057)) ([b491a07](b491a07))
* **BorrowerProfile:** show delinquent status on the borrower profile ([2a520d8](2a520d8))
* **LendCta:** keep CTA in loading state until user query resolves ([9f37605](9f37605))
* **MP-2947:** pair Almost Funded with lending stats in Keep your impact going ([#7054](#7054)) ([dd84819](dd84819))
* resolve comments to avoid extending the loan purchase work to rely on progress per year ([ef65943](ef65943))
* spacing issues in bp ([82aa729](82aa729))
* update stats typography in borrower profile ([79eb2d2](79eb2d2))
* use kv avatar component with integration fallback ([#7053](#7053)) ([7b0c563](7b0c563))

### 🔍 Tests

* **LendCta:** add story for loading state while user query pending ([7e6d3e4](7e6d3e4))
@kiva-robot

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 3.77.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

kiva-robot added a commit that referenced this pull request Jul 15, 2026
## [3.77.0](v3.76.0...v3.77.0) (2026-07-15)

### 🎉 New Features

* add new helper to retrieve goal in review information and test query timing ([5c93e00](5c93e00))
* borrower profile migration AD-1 ([#7044](#7044)) ([8647a8d](8647a8d))
* implement migrated withdraw-beta pages ([#7043](#7043)) ([45bef37](45bef37))
* **MP-2947:** roll out Almost Funded next step, remove lending stat experiment ([#7042](#7042)) ([9667beb](9667beb))
* **MP-3036:** add AI loan pills to the goal recommended-loan card ([#7056](#7056)) ([bec1b6f](bec1b6f))
* roll out AI loan pills across My Kiva, Checkout, and borrower profile ([#7051](#7051)) ([94fbc2d](94fbc2d))

### 🐛 Bugfixes

* add goal summary monolith query ([d382045](d382045))
* beta page fixes ([#7057](#7057)) ([b491a07](b491a07))
* **BorrowerProfile:** show delinquent status on the borrower profile ([2a520d8](2a520d8))
* capture tooltip id in setup instead of computed ([cefde31](cefde31))
* **LendCta:** keep CTA in loading state until user query resolves ([9f37605](9f37605))
* **LoanTags:** derive selected tag state from the current user's tags ([5e5e490](5e5e490))
* **MP-2947:** pair Almost Funded with lending stats in Keep your impact going ([#7054](#7054)) ([dd84819](dd84819))
* resolve comments to avoid extending the loan purchase work to rely on progress per year ([ef65943](ef65943))
* spacing issues in bp ([82aa729](82aa729))
* update stats typography in borrower profile ([79eb2d2](79eb2d2))
* use kv avatar component with integration fallback ([#7053](#7053)) ([7b0c563](7b0c563))

### 🔍 Tests

* **LendCta:** add story for loading state while user query pending ([7e6d3e4](7e6d3e4))

### 🧹 Chores

* **MP-2992:** roll out mykiva_goal_tile experiment, remove assignment code ([#7059](#7059)) ([b16316c](b16316c))
* **release:** 3.77.0-rc.1 [skip ci] ([6ed5d35](6ed5d35)), closes [#7044](#7044) [#7043](#7043) [#7042](#7042) [#7056](#7056) [#7051](#7051) [#7057](#7057) [#7054](#7054) [#7053](#7053)
* **release:** 3.77.0-rc.2 [skip ci] ([4a283e0](4a283e0)), closes [#7059](#7059)
* **release:** 3.77.0-rc.3 [skip ci] ([3fd8195](3fd8195))
@kiva-robot

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 3.77.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b2c Sends B2C team a message in Slack on PR creation released on @staging released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants