Validate SIDX reference field limits during encoding

[kixelated]

Summary

• Reject oversized reference_size, sap_type, and sap_delta_time values before encoding sidx references.
• Simplify SAP bit packing by using the already validated field values directly.
• Add coverage for the new TooLarge error path.

Testing

• Not run (not requested)
• Merge conflicts and CI failures were not verified in this context

[coderabbitai]

Walkthrough

The extended Sidx body encoder now rejects SegmentReference values that exceed the bit widths of reference_size, sap_type, or sap_delta_time, returning Error::TooLarge(Sidx::KIND). SAP field packing no longer masks validated values before shifting and combining them. A unit test verifies encoding fails for each oversized field.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: validating SIDX reference field limits during encoding.
Description check	✅ Passed	The description matches the implemented changes and test coverage.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/investigate-issue-189

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[bradh]

@CodeRabbit review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

🧹 Nitpick comments (1)

src/sidx.rs (1)

117-122: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Use branchless bitwise logic to simplify packing.

You can eliminate the match expression to avoid potential clippy::match_bool violations. As per coding guidelines, code must be clippy-clean. Casting the boolean to a u32 and shifting it directly makes the packing branchless, mathematically equivalent, and more concise.

♻️ Proposed refactor

-            let sap_flag_and_type_and_delta_time = match reference.starts_with_sap {
-                true => {
-                    0x8000_0000 | ((reference.sap_type as u32) << 28) | reference.sap_delta_time
-                }
-                false => ((reference.sap_type as u32) << 28) | reference.sap_delta_time,
-            };
+            let sap_flag_and_type_and_delta_time = ((reference.starts_with_sap as u32) << 31)
+                | ((reference.sap_type as u32) << 28)
+                | reference.sap_delta_time;

(Note: You can apply the same branchless simplification to reference_type_and_size on lines 111-114.)

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/sidx.rs` around lines 117 - 122, Replace the boolean match used to
compute sap_flag_and_type_and_delta_time with branchless bitwise packing by
casting reference.starts_with_sap to u32 and shifting it into the high flag bit,
preserving the existing sap_type and sap_delta_time fields. Apply the same
match_bool refactor to reference_type_and_size, using its corresponding boolean
flag and bit layout.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/sidx.rs`:
- Around line 117-122: Replace the boolean match used to compute
sap_flag_and_type_and_delta_time with branchless bitwise packing by casting
reference.starts_with_sap to u32 and shifting it into the high flag bit,
preserving the existing sap_type and sap_delta_time fields. Apply the same
match_bool refactor to reference_type_and_size, using its corresponding boolean
flag and bit layout.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 44ae5032-bf10-44fb-82f4-bf1c2898f1e1

📥 Commits

Reviewing files that changed from the base of the PR and between ac798db and 010e69b.

📒 Files selected for processing (1)

• src/sidx.rs