refactor: lower cognitive complexity ceiling - #39
Conversation
Split dense verification, revocation, parse, and PKITS harness paths into smaller typed branches so lint complexity limits stop fighting core PKIX behavior.
Split dense DER, PKCS, revocation, verify, parse, and docs paths into smaller typed helpers so Biome can enforce a stricter cognitive complexity limit.
📝 WalkthroughWalkthroughThis PR decomposes internal DER, cryptographic, X.509, certificate-verification, CRL, OCSP, and documentation implementations into focused helpers. It also updates editor and linter settings, test harness gating, PKITS and OpenSSL utilities, and malformed-extension test reuse. Public APIs and exported signatures remain unchanged. Estimated code review effort: 5 (Critical) | ~120 minutes Possibly related PRs
Suggested labels: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 4❌ Failed checks (4 warnings)
✅ Passed checks (4 passed)
Comment |
commit: |
This comment was marked as spam.
This comment was marked as spam.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
micro509 | 1075af5 | Commit Preview URL Branch Preview URL |
Jul 12 2026, 05:42 PM |
Keep `any` policy validation and empty-interface rendering intact, reuse AKI comparison logic, and tighten affected regression checks.
Keep expected trust-anchor verification failures in the signature result ADT while allowing unexpected exceptions to propagate. Exercise `any` policy handling with a policy-bearing chain.
Add focused helper JSDoc and update the changelog and knowledge files so architecture ownership, validation guidance, and PR documentation checks reflect the refactored structure.
Summary
Verification
bun lint:biomebun typecheckbun test(1184 pass, 0 fail)