Skip to content

fix(docs): preserve negotiation headers in production - #130

Merged
kl3inIT merged 1 commit into
mainfrom
fix/docs-negotiation-cache
Jul 29, 2026
Merged

fix(docs): preserve negotiation headers in production#130
kl3inIT merged 1 commit into
mainfrom
fix/docs-negotiation-cache

Conversation

@kl3inIT

@kl3inIT kl3inIT commented Jul 29, 2026

Copy link
Copy Markdown
Owner

Why

Live verification after PR #129 showed that production-generated HTML responses did not preserve the Accept negotiation boundary even though the reverse proxy supplied it. A shared cache could therefore confuse HTML and Markdown representations of the same docs URL.

What changed

  • declare Vary: Accept on both English and Vietnamese document routes in Next.js
  • run Playwright against a production build instead of next dev
  • cover HTML and Markdown variants for both locale roots
  • document the application/proxy cache boundary

Validation

  • corepack pnpm --filter @orgmemory/docs check
  • corepack pnpm --filter @orgmemory/docs test:e2e (20 passed, 2 skipped)
  • corepack pnpm --filter @orgmemory/docs check:output
  • git diff --check

Deployment note

This is a follow-up to the production verification of PR #129. After merge, build and deploy the exact merge SHA, then verify Vary: Accept directly on docs.kl3in.tech before closing the loop.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@kl3inIT, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 28 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 6154559b-62fe-4c1e-ab8a-3b4efb62592c

📥 Commits

Reviewing files that changed from the base of the PR and between 60b098a and 187479f.

📒 Files selected for processing (5)
  • apps/docs/ARCHITECTURE.md
  • apps/docs/next.config.mjs
  • apps/docs/package.json
  • apps/docs/playwright.config.ts
  • apps/docs/test/e2e/navigation.spec.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kl3inIT
kl3inIT merged commit ab35615 into main Jul 29, 2026
14 checks passed
@kl3inIT
kl3inIT deleted the fix/docs-negotiation-cache branch July 29, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant