fix(graph-rag): correct multi-snapshot gate evidence per PR #296 review - #297
Conversation
|
Warning Review limit reached
Next review available in: 21 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
TegamiThis repository uses Tegami to manage releases. When your changes affect published packages, add a changelog file under Create a changelog → · Changelog format Release preview
This PR does not add changelog files. Pending changelogs from other branches are included in the preview above. Run Managed by Tegami. |
Summary
Addresses all 16 CodeRabbit findings from #296 (merged before findings were read — loop repair; each comment on #296 receives a disposition reply referencing this PR).
Evidence-validity fixes: five-sample "p95/p99" replaced by honest median/observed-max labels (
results.mdregenerated — the ADR 0020 latency gate remains FAIL, now proven at the median: 17/72 rows over 500 ms, all at the largest scale); equivalence scenarios assert non-empty expected candidate counts;acl_generationis enforced in entity/relation/vector evidence with negative tests;SET statement_timeoutrestored to DEFAULT infinally;DISCARD PLANStargets the measured connection.Mechanical: typed query methods, Jackson for scope payloads and EXPLAIN parsing, SQLState-only timeout detection, LF report endings, single report write per scenario,
top_k=40contract enforcement in the recall schema, committedtmp/handoff removed from tracking.Skipped (1):
PostgreSQLContainer<?>— the resolved Testcontainers class in this build is non-generic; the suggested change fails compilation.Implementation by Codex
gpt-5.6-sol(high) under handoff; coordinator-reviewed. JetBrains inspection recorded as outstanding for the two edited Java files.Verification
Opt-in benchmark re-run: 72 scenarios in 4m47s, verdict unchanged (FAIL 17/72). Focused tests PASS;
uv run --frozen pytest38 PASS;ruffPASS; terminatingclean testPASS.skip-release: test-scope evidence correction only.
🤖 Generated with Claude Code