Skip to content

fix(graph-rag): correct multi-snapshot gate evidence per PR #296 review - #297

Merged
kl3inIT merged 1 commit into
mainfrom
fix/msq-bench-review
Aug 5, 2026
Merged

fix(graph-rag): correct multi-snapshot gate evidence per PR #296 review#297
kl3inIT merged 1 commit into
mainfrom
fix/msq-bench-review

Conversation

@kl3inIT

@kl3inIT kl3inIT commented Aug 5, 2026

Copy link
Copy Markdown
Owner

Summary

Addresses all 16 CodeRabbit findings from #296 (merged before findings were read — loop repair; each comment on #296 receives a disposition reply referencing this PR).

Evidence-validity fixes: five-sample "p95/p99" replaced by honest median/observed-max labels (results.md regenerated — the ADR 0020 latency gate remains FAIL, now proven at the median: 17/72 rows over 500 ms, all at the largest scale); equivalence scenarios assert non-empty expected candidate counts; acl_generation is enforced in entity/relation/vector evidence with negative tests; SET statement_timeout restored to DEFAULT in finally; DISCARD PLANS targets the measured connection.

Mechanical: typed query methods, Jackson for scope payloads and EXPLAIN parsing, SQLState-only timeout detection, LF report endings, single report write per scenario, top_k=40 contract enforcement in the recall schema, committed tmp/ handoff removed from tracking.

Skipped (1): PostgreSQLContainer<?> — the resolved Testcontainers class in this build is non-generic; the suggested change fails compilation.

Implementation by Codex gpt-5.6-sol (high) under handoff; coordinator-reviewed. JetBrains inspection recorded as outstanding for the two edited Java files.

Verification

Opt-in benchmark re-run: 72 scenarios in 4m47s, verdict unchanged (FAIL 17/72). Focused tests PASS; uv run --frozen pytest 38 PASS; ruff PASS; terminating clean test PASS.

skip-release: test-scope evidence correction only.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@kl3inIT, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 21 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 726c07a6-1072-4437-9e37-947087975342

📥 Commits

Reviewing files that changed from the base of the PR and between 475793d and 92a75e7.

⛔ Files ignored due to path filters (1)
  • docs/increments/active/2026-08-05-multi-snapshot-query-prototype/results.md is excluded by !docs/**
📒 Files selected for processing (5)
  • evaluation/src/orgmemory_eval/retrieval_recall.py
  • evaluation/tests/test_retrieval_recall.py
  • integrations/graph-rag-postgres/src/test/java/com/orgmemory/graphrag/postgres/AuthorizedMultiSnapshotQuery.java
  • integrations/graph-rag-postgres/src/test/java/com/orgmemory/graphrag/postgres/AuthorizedMultiSnapshotQueryIntegrationTests.java
  • tmp/handoff-msq-prototype-done.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Tegami

This repository uses Tegami to manage releases. When your changes affect published packages, add a changelog file under .tegami/ before merging.

Create a changelog → · Changelog format

Release preview

Package Bump Version
orgmemory minor 0.2.00.3.0

This PR does not add changelog files. Pending changelogs from other branches are included in the preview above.

Run pnpm run tegami locally to create a changelog interactively.

Managed by Tegami.

@kl3inIT
kl3inIT merged commit 93977a1 into main Aug 5, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant