Skip to content

fix(tcr-card): use valid networkId in place of undefined chainId #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2022
Merged

fix(tcr-card): use valid networkId in place of undefined chainId #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33b5e06
fix(tcr-card): use valid networkId in place of undefined chainId
gratestas Sep 20, 2022
122f8bb
fix: light curate, stop passing chainId as props
greenlucid Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions src/components/light-tcr-card-content.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,17 +29,10 @@ const StyledResult = styled(Result)`

const TCRCardContent = ({
tcrAddress,
chainId,
currentTCRAddress,
ID,
hideDetailsButton
}) => {
console.log({
tcrAddress,
currentTCRAddress,
ID,
hideDetailsButton
})
const { library, active, networkId } = useWeb3Context()
const [error, setError] = useState()
const gtcr = useMemo(() => {
Expand Down Expand Up @@ -83,12 +76,12 @@ const TCRCardContent = ({
</StyledItemCol>
<StyledItemCol>
{!hideDetailsButton && (
<Link to={`/tcr/${chainId}/${currentTCRAddress}/${ID}`}>
<Link to={`/tcr/${networkId}/${currentTCRAddress}/${ID}`}>
<Button>Details</Button>
</Link>
)}
<Link
to={`/tcr/${chainId}/${tcrAddress}`}
to={`/tcr/${networkId}/${tcrAddress}`}
style={{ marginLeft: '12px' }}
>
<Button type="primary">Open List</Button>
Expand Down Expand Up @@ -130,12 +123,12 @@ const TCRCardContent = ({
</div>
<StyledItemCol>
{!hideDetailsButton && (
<Link to={`/tcr/${chainId}/${currentTCRAddress}/${ID}`}>
<Link to={`/tcr/${networkId}/${currentTCRAddress}/${ID}`}>
<Button>Details</Button>
</Link>
)}
<Link
to={`/tcr/${chainId}/${tcrAddress}`}
to={`/tcr/${networkId}/${tcrAddress}`}
style={{ marginLeft: '12px' }}
>
<Button type="primary">Open List</Button>
Expand Down
9 changes: 4 additions & 5 deletions src/components/tcr-card-content.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ const StyledResult = styled(Result)`

const TCRCardContent = ({
tcrAddress,
chainId,
currentTCRAddress,
ID,
hideDetailsButton
Expand Down Expand Up @@ -77,12 +76,12 @@ const TCRCardContent = ({
</StyledItemCol>
<StyledItemCol>
{!hideDetailsButton && (
<Link to={`/tcr/${chainId}/${currentTCRAddress}/${ID}`}>
<Link to={`/tcr/${networkId}/${currentTCRAddress}/${ID}`}>
<Button>Details</Button>
</Link>
)}
<Link
to={`/tcr/${chainId}/${tcrAddress}`}
to={`/tcr/${networkId}/${tcrAddress}`}
style={{ marginLeft: '12px' }}
>
<Button type="primary">Open List</Button>
Expand Down Expand Up @@ -124,12 +123,12 @@ const TCRCardContent = ({
</div>
<StyledItemCol>
{!hideDetailsButton && (
<Link to={`/tcr/${chainId}/${currentTCRAddress}/${ID}`}>
<Link to={`/tcr/${networkId}/${currentTCRAddress}/${ID}`}>
<Button>Details</Button>
</Link>
)}
<Link
to={`/tcr/${chainId}/${tcrAddress}`}
to={`/tcr/${networkId}/${tcrAddress}`}
style={{ marginLeft: '12px' }}
>
<Button type="primary">Open List</Button>
Expand Down
1 change: 0 additions & 1 deletion src/pages/items/item-card.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@ const CardItemInfo = ({
content = isTCRofTCRs ? (
<TCRCardContent
ID={item.tcrData.ID}
chainId={chainId}
tcrAddress={item.columns[0].value}
itemName={itemName}
currentTCRAddress={tcrAddress}
Expand Down
1 change: 0 additions & 1 deletion src/pages/light-items/item-card.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@ const CardItemInfo = ({
content = isTCRofTCRs ? (
<TCRCardContent
ID={item.tcrData.ID}
chainId={chainId}
tcrAddress={item.columns[0].value}
itemName={itemName}
currentTCRAddress={tcrAddress}
Expand Down