Skip to content

Conversation

@gratestas
Copy link
Contributor

updated the footer and added block explorer links to light/classic TCR

fixes #166 #167

@gratestas gratestas requested a review from greenlucid October 21, 2022 12:52
@greenlucid
Copy link
Contributor

On #166: The footer still exists. There's an Etherscan icon but it just links to the TCR page it's being rendered on. Were you intending on removing it?

It doesn't say "Secured by Kleros" as #167 mentions. Was "Secured by Kleros" decided to be scrapped? In that case #167 should just be closed.

@gratestas
Copy link
Contributor Author

gratestas commented Oct 26, 2022

@greenlucid Checked it and it seems good locally. This is how it renders

image

The intended change happens in this commit. A wrong version of the footer component is imported there. So I just changed the path

@greenlucid
Copy link
Contributor

I'm getting this instead. Did you push your changes?

image

@gratestas
Copy link
Contributor Author

@greenlucid yes, I did.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@greenlucid greenlucid merged commit 85936cd into master Oct 27, 2022
@greenlucid greenlucid deleted the fix/footer-explorer-link branch October 27, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kleros Curate etherescabn footer link

2 participants