This repository was archived by the owner on Jun 30, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 14
refactor: project wide clean up #83
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d9ff054
refactor: whole project
epiqueras 9954862
docs(readme): update readme
epiqueras 2302cc7
chore(dependencies): add webpack-cli
epiqueras f9480c0
fix: skip broken test assertions
epiqueras 8dfc204
chore(release): 0.0.61
epiqueras 946d113
cleanup while reviewing
satello a942f0b
refactor(kleros-wrapper): remove unnecessary eslint ignore
epiqueras File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,4 @@ | ||
| { | ||
| "presets": ["env"], | ||
| "plugins": [ | ||
| "transform-class-properties", | ||
| "transform-runtime" | ||
| ] | ||
| "presets": ["env", "stage-2"], | ||
| "plugins": ["transform-runtime"] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| repo_token: $COVERALLS_REPO_TOKEN |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| module.exports = { | ||
| source: './src', | ||
| destination: './docs', | ||
| plugins: [ | ||
| { name: 'esdoc-standard-plugin' }, | ||
| { name: 'esdoc-ecmascript-proposal-plugin', option: { all: true } } | ||
| ] | ||
| } |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| module.exports = { | ||
| extends: './node_modules/kleros-scripts/.eslintrc.js', | ||
| rules: { | ||
| 'unicorn/filename-case': 0 | ||
| } | ||
| } |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,24 @@ | ||
| # Dependency directory | ||
| # https://www.npmjs.org/doc/misc/npm-faq.html#should-i-check-my-node_modules-folder-into-git | ||
| node_modules | ||
| # See https://help.github.com/ignore-files/ for more about ignoring files. | ||
|
|
||
| # Remove some common IDE working directories | ||
| .idea | ||
| .vscode | ||
| # Dependencies | ||
| /node_modules/ | ||
|
|
||
| # Env configuration | ||
| .env | ||
| # Testing | ||
| /coverage/ | ||
|
|
||
| # built js | ||
| lib | ||
| # Documentation | ||
| /docs/ | ||
|
|
||
| # Files generated | ||
| package-lock.json | ||
| yarn-error.log | ||
| # Production | ||
| /lib/ | ||
|
|
||
| # docs | ||
| docs | ||
| # Logs | ||
| /yarn-debug.log* | ||
| /yarn-error.log* | ||
|
|
||
| # Editors | ||
| /.vscode/ | ||
| /.idea/* | ||
|
|
||
| # Misc | ||
| /.DS_Store |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,10 @@ | ||
| # Dependencies | ||
| /yarn.lock | ||
|
|
||
| # Configuration | ||
| .* | ||
| config.json | ||
| webpack.config.js | ||
| yarn.lock | ||
| docs | ||
|
|
||
| # Documentation | ||
| /docs/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,20 @@ | ||
| language: node_js | ||
| node_js: | ||
| - "stable" | ||
| - v9.4.0 | ||
| cache: | ||
| directories: | ||
| - node_modules | ||
| script: | ||
| - yarn build | ||
| - yarn test | ||
| - node_modules | ||
| yarn: true | ||
| addons: | ||
| apt: | ||
| sources: | ||
| - ubuntu-toolchain-r-test | ||
| install: | ||
| - yarn | ||
| - nohup yarn run testrpc & | ||
| install: yarn install --pure-lockfile | ||
| script: | ||
| - yarn run lint | ||
| - nohup yarn run ganache-cli & | ||
| - yarn test | ||
| - 'yarn run test:coveralls' | ||
| - yarn run build | ||
| notifications: | ||
| slack: kleros:Ub8n81EgKJ3iRrMDyWyQIVJp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # Change Log | ||
|
|
||
| All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines. | ||
|
|
||
| <a name="0.0.61"></a> | ||
|
|
||
| ## 0.0.61 (2018-02-27) | ||
|
|
||
| ### Bug Fixes | ||
|
|
||
| * **getDeadlineForDispute:** fix wrong computation and return date object ([7ee05f5](https://github.com/kleros/kleros-api/commit/7ee05f5)) | ||
| * skip broken test assertions ([f9480c0](https://github.com/kleros/kleros-api/commit/f9480c0)) | ||
| * test suite ([98b777d](https://github.com/kleros/kleros-api/commit/98b777d)) | ||
|
|
||
| ### Features | ||
|
|
||
| * normalize token units ([d0d40f8](https://github.com/kleros/kleros-api/commit/d0d40f8)) | ||
| * **disputes:** build voteCounters and PNKRepartitions from getters ([ba48e67](https://github.com/kleros/kleros-api/commit/ba48e67)) | ||
| * **disputes:** change approach to getting netPNK and votesCounter ([366340f](https://github.com/kleros/kleros-api/commit/366340f)) | ||
| * **disputes:** remove netPNK until events are fixed ([255bf03](https://github.com/kleros/kleros-api/commit/255bf03)) | ||
| * **disputes:** return appealsRepartitioned ([1246968](https://github.com/kleros/kleros-api/commit/1246968)) | ||
| * **disputes:** return deadline as epoch in ms instead of a date object ([90d4856](https://github.com/kleros/kleros-api/commit/90d4856)) | ||
| * **disputes:** return dispute status ([32db45c](https://github.com/kleros/kleros-api/commit/32db45c)) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should be on 0.0.62 now
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? Refactors don't bump versions, https://semver.org.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure but these changes weren't from 0.0.61 anyways right? Also changelogs are nice but I still think we are a little early since we really don't even have a stable v1 yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'm pretty sure those changes were included in that release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm i see whats going on