Skip to content

feat(web): style scrollbar a bit and add placeholder if not scrollabl… #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 15, 2023
Merged

feat(web): style scrollbar a bit and add placeholder if not scrollabl… #1229

merged 6 commits into from
Sep 15, 2023

Conversation

@kemuru
Copy link
Contributor

@kemuru kemuru commented Sep 13, 2023

…e section

closes #1213

@netlify
Copy link

netlify bot commented Sep 13, 2023 •
edited
Loading

✅ Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit 2288b77
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/650177f7fa1ef40008734da9
😎 Deploy Preview https://deploy-preview-1229--kleros-v2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Sep 13, 2023

Code Climate has analyzed commit 2288b77 and detected 0 issues on this pull request.

View more on Code Climate.

@alcercu alcercu changed the base branch from dev to web-staging September 13, 2023 09:44
alcercu
alcercu suggested changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but there is a small bug; When the phone is sideways, the hamburger menu doesn't fit entirely, and you are not able to scroll
image

@kemuru
Copy link
Contributor Author

kemuru commented Sep 15, 2023 •
edited
Loading

Looking good, but there is a small bug; When the phone is sideways, the hamburger menu doesn't fit entirely, and you are not able to scroll image

the fix created side effects which made me restructure some code. if you merge I'll need to do the same update for Desktop PR

alcercu
alcercu approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alcercu alcercu merged commit 0c056c0 into web-staging Sep 15, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jaybuidl jaybuidl deleted the feat(web)/new-scrollbar-and-placeholder branch September 26, 2023 13:10
@kemuru kemuru mentioned this pull request Oct 4, 2023
Closed
@jaybuidl jaybuidl added this to the testnet-2 milestone Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alcercu alcercu alcercu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Package: Web Court web frontend Type: Enhancement ✨ Type: UX User Experience

Projects

None yet

Milestone

testnet-2

Development

Successfully merging this pull request may close these issues.

Web: make scroll bar more stylish

4 participants

@kemuru @alcercu @jaybuidl