fix: guard overlay timestamp assignment against undefined in pressed move - #817
Merged
liihuu merged 1 commit intoAug 2, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
OverlayImp.eventPressedPointMoveassignspoint.timestampunconditionally,while the sibling fields (
dataIndex,value) are guarded withisNumber:pointis built byOverlayView._coordinateToPoint, which setstimestamp = chartStore.dataIndexToTimestamp(dataIndex) ?? undefined.dataIndexToTimestampreturnsnullwhendataListis empty or the lookupfails and no period is configured (
src/Store.ts:950). In that casepoint.timestampisundefined, and this line overwrites a previously validtimestamp on the dragged point — dropping the point from its time-based
placement for overlays placed by
{ timestamp, value }.Fix
Guard the assignment the same way the sibling fields (and the other move
handlers in this file) are guarded:
eventPressedPointMove(point: Partial<Point>, pointIndex: number): void { - this.points[pointIndex].timestamp = point.timestamp + if (isNumber(point.timestamp)) { + this.points[pointIndex].timestamp = point.timestamp + } if (isNumber(point.dataIndex)) {The same
if (isNumber(point.timestamp))guard is already used by the twoneighbouring move handlers in this file (
continuousDrawingModeEventMoveForDrawingand
stepDrawingModeEventMoveForDrawing), so this bringseventPressedPointMovein line with them.
Verification
pnpm type-check— pass (exit 0)pnpm build-esm(runscode-lintvia biome, then ESM build) — pass (154 files checked, no fixes, exit 0)Notes
dataIndex/valuehandling and theperformEventPressedMovecallback are untouched.