ci: Fix html files not being built - #455
Closed
lucasdemarchi wants to merge 4 commits into
Closed
Conversation
evelikov
reviewed
Aug 6, 2026
evelikov
left a comment
evelikov
left a comment
Collaborator
There was a problem hiding this comment.
A while ago, I was thinking of a slightly different approach:
- trigger on tag push
- iterate all tags, generate the docs for each - older versions might need different build command
- for each missing -> push to staging
- for each re-generated -> flag the diff, allow to continue manually (gitlab has manual job triggers, don't recall if GH does) or via special env. variable
- once staging is full -> release
Collaborator
|
I am loving the |
Contributor
Author
right... but I started this only to generate v34, not anything older than that. We can go back and do that, but then maybe we don't need it this github workflow... |
libkmod-3-docs is too long and hard to remember. Add an alias. Signed-off-by: Lucas De Marchi <demarchi@kernel.org>
The html docs is not build by default. Also, there's no need to build anything else: the custom target for docs can be executed directly. Finally, move to the newly-introduced 'docs' alias. Signed-off-by: Lucas De Marchi <demarchi@kernel.org>
Add a workflow_dispatch that accepts the tag as input. This should allow docs to be generated for a past release and populate the https://kmod-project.github.io/ website. Signed-off-by: Lucas De Marchi <demarchi@kernel.org>
lucasdemarchi
force-pushed
the
tip-fix-docs
branch
from
August 7, 2026 04:34
fa2961a to
0bccde1
Compare
Allow to build all man pages without depending on the rest of the build. Signed-off-by: Lucas De Marchi <demarchi@kernel.org>
evelikov
approved these changes
Aug 8, 2026
evelikov
left a comment
evelikov
left a comment
Collaborator
There was a problem hiding this comment.
Don't have the means to quickly test and overall it looks good.
lucasdemarchi
added a commit
that referenced
this pull request
Aug 10, 2026
libkmod-3-docs is too long and hard to remember. Add an alias. Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com> Link: #455 Signed-off-by: Lucas De Marchi <demarchi@kernel.org>
lucasdemarchi
added a commit
that referenced
this pull request
Aug 10, 2026
The html docs is not build by default. Also, there's no need to build anything else: the custom target for docs can be executed directly. Finally, move to the newly-introduced 'docs' alias. Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com> Link: #455 Signed-off-by: Lucas De Marchi <demarchi@kernel.org>
lucasdemarchi
added a commit
that referenced
this pull request
Aug 10, 2026
Add a workflow_dispatch that accepts the tag as input. This should allow docs to be generated for a past release and populate the https://kmod-project.github.io/ website. Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com> Link: #455 Signed-off-by: Lucas De Marchi <demarchi@kernel.org>
lucasdemarchi
added a commit
that referenced
this pull request
Aug 10, 2026
Allow to build all man pages without depending on the rest of the build. Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com> Link: #455 Signed-off-by: Lucas De Marchi <demarchi@kernel.org>
Contributor
Author
|
Applied, thanks |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also (hopefully) allow to generate docs for past releases.