Skip to content

fix(ode): handle zero-dimensional RK45 states - #174

Merged
kmolan merged 2 commits into
kmolan:mainfrom
terminalchai:fix/159-zero-dimensional-rk45
Jul 17, 2026
Merged

fix(ode): handle zero-dimensional RK45 states#174
kmolan merged 2 commits into
kmolan:mainfrom
terminalchai:fix/159-zero-dimensional-rk45

Conversation

@terminalchai

Copy link
Copy Markdown
Contributor

Returns zero from RK45's RMS helpers for zero-dimensional states, preventing 0/0 from producing NaN and exhausting the step budget. Adds a public regression test that integrates Vector<0, f64> and records the fix in the changelog.

Fixes #159.

@terminalchai
terminalchai requested a review from kmolan as a code owner July 17, 2026 20:33

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the first PR! 🎉 You'll get a first review within 48 h. CI runs the 5-target matrix — a budget-gate failure isn't your fault, see ci/README.md.

Comment thread crates/multicalc/src/ode/rk45.rs
@kmolan
kmolan merged commit 170aca7 into kmolan:main Jul 17, 2026
16 checks passed
@kmolan

kmolan commented Jul 17, 2026

Copy link
Copy Markdown
Owner

@terminalchai thanks for the contribution! Hope to see more coming 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Guard the RK45 norms against a zero-dimensional state

2 participants