Don't show warnings that are not bad conditions#339
Don't show warnings that are not bad conditions#339duglin wants to merge 1 commit intoknative:masterfrom
Conversation
Don't show warnings when running `kn plugin list`: - a dir in your plug-in path doesn't exist - e.g. right now it shows it for a missing ~/.kn/plugins - which is a valid state for someone who just downloaded `kn` but doesn't have, or need, a .kn dir - there are no plugins at all - that's a valid state and doesn't deserve a warning To me warning are things people need to be aware of (or things they need to take action to fix). Neither of those case apply here. Instead they user will just be annoyed by this: ``` $ kn plugin list Unable read directory '/root/.kn/plugins' from your plugins path: open /root/.kn/plugins: no such file or directory. Skipping... warning: unable to find any kn plugins in your plugin path: '[/root/.kn/plugins]' ``` When they should see no output at all. Or, if someone wants to add it we coudl output `no plugins found` but not call it a "warning" since it's not. Signed-off-by: Doug Davis <dug@us.ibm.com>
knative-prow-robot
left a comment
knative-prow-robot
left a comment
There was a problem hiding this comment.
@duglin: 0 warnings.
Details
In response to this:
Don't show warnings while running
kn plugin listwhen:
- a dir in your plug-in path doesn't exist - e.g. right now it shows it for a missing ~/.kn/plugins - which is a valid state for someone who just downloaded
knbut doesn't have, or need, a .kn dir- there are no plugins at all - that's a valid state and doesn't deserve a warning
To me warning are things people need to be aware of (or things they need to
take action to fix). Neither of those case apply here. Instead they user
will just be annoyed by this:$ kn plugin list Unable read directory '/root/.kn/plugins' from your plugins path: open /root/.kn/plugins: no such file or directory. Skipping... warning: unable to find any kn plugins in your plugin path: '[/root/.kn/plugins]'When they should see no output at all. Or, if someone wants to add it we could output
no plugins foundbut not call it a "warning" since it's not.Signed-off-by: Doug Davis dug@us.ibm.com
/lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: duglin The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
knative-prow-robot
added
the
size/M
|
The following is the coverage report on pkg/.
|
|
Fixed with #313 |
|
@rhuss as long as the conditions I listed don't result in warning then yes! :-) |
|
@duglin: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
ok, let's close this and continue on #333 |
6 participants
Don't show warnings while running
kn plugin listwhen:knbut doesn't have, or need, a .kn dirTo me warning are things people need to be aware of (or things they need to
take action to fix). Neither of those case apply here. Instead they user
will just be annoyed by this:
When they should see no output at all. Or, if someone wants to add it we could output
no plugins foundbut not call it a "warning" since it's not.Signed-off-by: Doug Davis dug@us.ibm.com
/lint