Skip to content

Conversation

@samodell
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 14, 2019
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 14, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@samodell
Copy link
Contributor Author

Fixes #401 for Docs; I'll also add this info to the templates in the other repos.

@samodell
Copy link
Contributor Author

Opened knative/serving#3431

If that one goes in, I'll open similar PRs in the other repos.

Copy link
Contributor

@gyliu513 gyliu513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2019
@knative-prow-robot knative-prow-robot merged commit 441dd41 into master Mar 15, 2019
@RichieEscarez RichieEscarez deleted the samodell-patch-4 branch March 15, 2019 20:20
vorburger added a commit to vorburger/docs that referenced this pull request Mar 19, 2019
* master:
  fix serving directory path (knative#1015)
  site: insert 'docs' container folder at root (for knative.dev) (knative#1007)
  hack: update ref docs gen script to cleanup tmp dirs (knative#1001)
  hack: configurable repo refs for api docs gen (knative#998)
  Update traffic splitting example to use Release mode (knative#964)
  Update Eventing cronjob-source for Cloudevents (knative#1006)
  Update issue templates -- delete extra template, add security note (knative#1003)
  Update issue templates -- separate feature request from new/changing functionality (knative#1002)
  Clarifying Docs contributor roles (knative#958)
  update OpenShift on install (knative#975)
  Update the monitoring file version (knative#996)
  Update Dockerfile (knative#991)
  update Knative-with-OpenShift from 3.10 to 3.11 (and minor clean up) (knative#974)
  make install/scripts/knative-with-openshift.sh +x and -e (knative#973)
  fix wrong path (knative#989)
  Update README.md (knative#987)
  Change MiniKube installation to require 1.12 cluster. (knative#873)
  fix typo (knative#963)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants