Update traffic splitting example to use Release mode #964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
do-not-merge/work-in-progress
knative-prow-robot
added
the
size/L
dgerd
force-pushed
the
traffic-split
branch
4 times, most recently
from
d3d6e17 to
8161d77
Compare
dgerd
changed the title
knative-prow-robot
removed
the
do-not-merge/work-in-progress
Author
|
/assign @samodell |
knative-prow-robot
added
lgtm
added 3 commits
March 7, 2019 17:50
This change updates the traffic splitting example to use release mode introducing the concepts of the mode in three steps. This change also simplifies running the commands and removes the need to mutate files on disk to run through the example.
Author
|
@samodell ping. Can you take a look? |
Contributor
|
@dgerd Yep, I'll take a look first thing tomorrow. |
Contributor
|
This looks good! Thanks, @dgerd /approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgerd, samodell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
vorburger
added a commit
to vorburger/docs
that referenced
this pull request
Mar 19, 2019
* master: fix serving directory path (knative#1015) site: insert 'docs' container folder at root (for knative.dev) (knative#1007) hack: update ref docs gen script to cleanup tmp dirs (knative#1001) hack: configurable repo refs for api docs gen (knative#998) Update traffic splitting example to use Release mode (knative#964) Update Eventing cronjob-source for Cloudevents (knative#1006) Update issue templates -- delete extra template, add security note (knative#1003) Update issue templates -- separate feature request from new/changing functionality (knative#1002) Clarifying Docs contributor roles (knative#958) update OpenShift on install (knative#975) Update the monitoring file version (knative#996) Update Dockerfile (knative#991) update Knative-with-OpenShift from 3.10 to 3.11 (and minor clean up) (knative#974) make install/scripts/knative-with-openshift.sh +x and -e (knative#973) fix wrong path (knative#989) Update README.md (knative#987) Change MiniKube installation to require 1.12 cluster. (knative#873) fix typo (knative#963)
RichieEscarez
pushed a commit
to RichieEscarez/docs
that referenced
this pull request
Mar 29, 2019
Update traffic splitting example to use Release mode (knative#964) * Update traffic splitting example to use Release mode This change updates the traffic splitting example to use release mode introducing the concepts of the mode in three steps. This change also simplifies running the commands and removes the need to mutate files on disk to run through the example. * Use envsubst instead of perl. Simplify image path * Use long names for arguments * Update diff statement * Add envsubst install instructions
RichieEscarez
pushed a commit
to RichieEscarez/docs
that referenced
this pull request
Mar 29, 2019
Update traffic splitting example to use Release mode (knative#964) * Update traffic splitting example to use Release mode This change updates the traffic splitting example to use release mode introducing the concepts of the mode in three steps. This change also simplifies running the commands and removes the need to mutate files on disk to run through the example. * Use envsubst instead of perl. Simplify image path * Use long names for arguments * Update diff statement * Add envsubst install instructions
RichieEscarez
pushed a commit
to RichieEscarez/docs
that referenced
this pull request
Mar 29, 2019
Update traffic splitting example to use Release mode (knative#964) * Update traffic splitting example to use Release mode This change updates the traffic splitting example to use release mode introducing the concepts of the mode in three steps. This change also simplifies running the commands and removes the need to mutate files on disk to run through the example. * Use envsubst instead of perl. Simplify image path * Use long names for arguments * Update diff statement * Add envsubst install instructions
RichieEscarez
pushed a commit
to RichieEscarez/docs
that referenced
this pull request
Mar 29, 2019
Update traffic splitting example to use Release mode (knative#964) * Update traffic splitting example to use Release mode This change updates the traffic splitting example to use release mode introducing the concepts of the mode in three steps. This change also simplifies running the commands and removes the need to mutate files on disk to run through the example. * Use envsubst instead of perl. Simplify image path * Use long names for arguments * Update diff statement * Add envsubst install instructions
knative-prow-robot
pushed a commit
that referenced
this pull request
Mar 29, 2019
Update traffic splitting example to use Release mode (#964) * Update traffic splitting example to use Release mode This change updates the traffic splitting example to use release mode introducing the concepts of the mode in three steps. This change also simplifies running the commands and removes the need to mutate files on disk to run through the example. * Use envsubst instead of perl. Simplify image path * Use long names for arguments * Update diff statement * Add envsubst install instructions
knative-prow-robot
pushed a commit
that referenced
this pull request
Mar 29, 2019
Update traffic splitting example to use Release mode (#964) * Update traffic splitting example to use Release mode This change updates the traffic splitting example to use release mode introducing the concepts of the mode in three steps. This change also simplifies running the commands and removes the need to mutate files on disk to run through the example. * Use envsubst instead of perl. Simplify image path * Use long names for arguments * Update diff statement * Add envsubst install instructions
knative-prow-robot
pushed a commit
that referenced
this pull request
Mar 29, 2019
* Resolving bad merge with cherry-pick: Update traffic splitting example to use Release mode (#964) * Update traffic splitting example to use Release mode This change updates the traffic splitting example to use release mode introducing the concepts of the mode in three steps. This change also simplifies running the commands and removes the need to mutate files on disk to run through the example. * Use envsubst instead of perl. Simplify image path * Use long names for arguments * Update diff statement * Add envsubst install instructions * remove dup file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This change updates the traffic splitting example to use release mode
introducing the concepts of the mode in three steps. This change also
simplifies running the commands and removes the need to mutate files on
disk to run through the example.