Skip to content

fix typo #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2019
Merged

fix typo #963

merged 1 commit into from
Mar 11, 2019

Conversation

@DaveSlinn
Copy link
Contributor

@DaveSlinn DaveSlinn commented Mar 6, 2019

Fixes #(issue-number)

Proposed Changes

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 6, 2019
@googlebot
Copy link

googlebot commented Mar 6, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Indicates the PR's author has not signed the CLA. label Mar 6, 2019
@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 6, 2019
@DaveSlinn
Copy link
Contributor Author

DaveSlinn commented Mar 6, 2019 via email

@samodell
Copy link
Contributor

samodell commented Mar 6, 2019

/ok-to-test

@knative-prow-robot knative-prow-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 6, 2019
@samodell
Copy link
Contributor

samodell commented Mar 6, 2019

@DaveSlinn Thanks for your PR! It looks like the CLA bot isn't satisfied yet -- can you double-check that the email you used to sign your commit is the same as the email you used when you signed the CLA? That's the most common problem.

@DaveSlinn
Copy link
Contributor Author

DaveSlinn commented Mar 9, 2019

Fixed it.

@googlebot
Copy link

googlebot commented Mar 9, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Mar 9, 2019
@samodell
Copy link
Contributor

samodell commented Mar 11, 2019

Thanks, @DaveSlinn !

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2019
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Mar 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DaveSlinn, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 93b6640 into knative:master Mar 11, 2019
vorburger added a commit to vorburger/docs that referenced this pull request Mar 19, 2019
@vorburger
Merge branch 'master' into knative-with-minishift-just-use-operators
869cc5d 
* master:
  fix serving directory path (knative#1015)
  site: insert 'docs' container folder at root (for knative.dev) (knative#1007)
  hack: update ref docs gen script to cleanup tmp dirs (knative#1001)
  hack: configurable repo refs for api docs gen (knative#998)
  Update traffic splitting example to use Release mode (knative#964)
  Update Eventing cronjob-source for Cloudevents (knative#1006)
  Update issue templates -- delete extra template, add security note (knative#1003)
  Update issue templates -- separate feature request from new/changing functionality (knative#1002)
  Clarifying Docs contributor roles (knative#958)
  update OpenShift on install (knative#975)
  Update the monitoring file version (knative#996)
  Update Dockerfile (knative#991)
  update Knative-with-OpenShift from 3.10 to 3.11 (and minor clean up) (knative#974)
  make install/scripts/knative-with-openshift.sh +x and -e (knative#973)
  fix wrong path (knative#989)
  Update README.md (knative#987)
  Change MiniKube installation to require 1.12 cluster. (knative#873)
  fix typo (knative#963)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carieshmarie carieshmarie Awaiting requested review from carieshmarie

@RichieEscarez RichieEscarez Awaiting requested review from RichieEscarez

Assignees

@samodell samodell

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DaveSlinn @googlebot @samodell @knative-prow-robot