Skip to content

Conversation

@danielgruesso
Copy link

Updating kubernetes secret creation instruction to correctly show which file should hold which data, ie. certificate on cert.pem and private key on cert.pk.

Fixes #issue-number

Proposed Changes

Updating kubernetes secret creation instruction to correctly show which file should hold which data, ie. certificate on `cert.pem` and private key on `cert.pk`.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Indicates the PR's author has not signed the CLA. label Jun 21, 2019
@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 21, 2019
@knative-prow-robot
Copy link
Contributor

Hi @danielgruesso. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 21, 2019
@danielgruesso
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Jun 22, 2019
@danielgruesso
Copy link
Author

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

I signed it!

@samodell
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielgruesso, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit e960702 into knative:release-0.6 Jun 25, 2019
samodell pushed a commit to samodell/docs that referenced this pull request Jun 25, 2019
Updating kubernetes secret creation instruction to correctly show which file should hold which data, ie. certificate on `cert.pem` and private key on `cert.pk`.
knative-prow-robot pushed a commit that referenced this pull request Jun 25, 2019
* Update order of files in example (#1501)

Updating kubernetes secret creation instruction to correctly show which file should hold which data, ie. certificate on `cert.pem` and private key on `cert.pk`.

* Update link for Knative Install on OpenShift via Operator (#1511)
RichieEscarez pushed a commit to RichieEscarez/docs that referenced this pull request Jun 26, 2019
* Update order of files in example (knative#1501)

Updating kubernetes secret creation instruction to correctly show which file should hold which data, ie. certificate on `cert.pem` and private key on `cert.pk`.

* Update link for Knative Install on OpenShift via Operator (knative#1511)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants