Skip to content

Updated link for Knative Install on OpenShift via Operator #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2019
Merged

Updated link for Knative Install on OpenShift via Operator #1511

merged 1 commit into from
Jun 25, 2019

Conversation

@nebelsprachen
Copy link
Contributor

@nebelsprachen nebelsprachen commented Jun 24, 2019 •
edited
Loading

Fixes #1510

Proposed Changes

  • Link to openshift-knative/docs repo

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 24, 2019
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Jun 24, 2019

Hi @joaedwar. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 24, 2019
@samodell
Copy link
Contributor

samodell commented Jun 25, 2019

/lgtm
/approve

@joaedwar FYI, we recommend making changes against the master branch and then cherry-picking the fixes back into the current release branch (IE, release-0.6). That way, if the cherry-picking is forgotten, at least the fix isn't lost. (Fixes not in master are not persisted to future releases.)

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2019
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Jun 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joaedwar, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@samodell
Copy link
Contributor

samodell commented Jun 25, 2019

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 25, 2019
@knative-prow-robot knative-prow-robot merged commit 9040aa6 into knative:release-0.6 Jun 25, 2019
samodell pushed a commit to samodell/docs that referenced this pull request Jun 25, 2019
@nebelsprachen @samodell
Update link for Knative Install on OpenShift via Operator (knative#1511)
6761b43
@samodell samodell mentioned this pull request Jun 25, 2019
Merged
knative-prow-robot pushed a commit that referenced this pull request Jun 25, 2019
@samodell @knative-prow-robot
Cherrypick release-0.6 --> master (#1523)
6486211 
* Update order of files in example (#1501)

Updating kubernetes secret creation instruction to correctly show which file should hold which data, ie. certificate on `cert.pem` and private key on `cert.pk`.

* Update link for Knative Install on OpenShift via Operator (#1511)
RichieEscarez pushed a commit to RichieEscarez/docs that referenced this pull request Jun 26, 2019
@samodell @RichieEscarez
Cherrypick release-0.6 --> master (knative#1523)
24ed36e 
* Update order of files in example (knative#1501)

Updating kubernetes secret creation instruction to correctly show which file should hold which data, ie. certificate on `cert.pem` and private key on `cert.pk`.

* Update link for Knative Install on OpenShift via Operator (knative#1511)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carieshmarie carieshmarie Awaiting requested review from carieshmarie

@RichieEscarez RichieEscarez Awaiting requested review from RichieEscarez

Assignees

@samodell samodell

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nebelsprachen @knative-prow-robot @samodell @googlebot @RichieEscarez