Skip to content

Cherrypick release-0.6 --> master #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 25, 2019
Merged

Cherrypick release-0.6 --> master #1523

merged 2 commits into from
Jun 25, 2019

Conversation

@samodell
Copy link
Contributor

@samodell samodell commented Jun 25, 2019

Cherry-pick batch

Included PRs:

#1501
#1511

danielgruesso and others added 2 commits June 25, 2019 13:26
@danielgruesso @samodell
Update order of files in example (knative#1501)
adbda7d 
Updating kubernetes secret creation instruction to correctly show which file should hold which data, ie. certificate on `cert.pem` and private key on `cert.pk`.
@nebelsprachen @samodell
Update link for Knative Install on OpenShift via Operator (knative#1511)
6761b43
@googlebot
Copy link

googlebot commented Jun 25, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Indicates the PR's author has not signed the CLA. label Jun 25, 2019
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Jun 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 25, 2019
@samodell
Copy link
Contributor Author

samodell commented Jun 25, 2019

Overriding CLA, since these commits have already been merged into the release 0.6 branch.

@samodell samodell added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Jun 25, 2019
@googlebot
Copy link

googlebot commented Jun 25, 2019

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@carieshmarie carieshmarie added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2019
@knative-prow-robot knative-prow-robot merged commit 6486211 into knative:master Jun 25, 2019
RichieEscarez pushed a commit to RichieEscarez/docs that referenced this pull request Jun 26, 2019
@samodell @RichieEscarez
Cherrypick release-0.6 --> master (knative#1523)
24ed36e 
* Update order of files in example (knative#1501)

Updating kubernetes secret creation instruction to correctly show which file should hold which data, ie. certificate on `cert.pem` and private key on `cert.pk`.

* Update link for Knative Install on OpenShift via Operator (knative#1511)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carieshmarie carieshmarie Awaiting requested review from carieshmarie

@RichieEscarez RichieEscarez Awaiting requested review from RichieEscarez

Assignees

@carieshmarie carieshmarie

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@samodell @googlebot @knative-prow-robot @carieshmarie @danielgruesso @nebelsprachen