Redirects image urls - #6684
Merged
Merged
Conversation
In Evan's book the example URL to use is docs/images/logo/rbg/knative-logo-rgb.png, however the file is actually served at /images/* without the docs prefix. Since the book is already out there, I figured the neatest solution to the problem I ran into when following his example code, is to make that URL valid.
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
|
Welcome @Hanse00! It looks like this is your first PR to knative/docs 🎉 |
knative-prow
Bot
added
the
size/XS
evankanderson
approved these changes
Aug 17, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson, Hanse00 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
Bot
added
the
approved
Member
|
/ok-to-test |
knative-prow
Bot
added
the
ok-to-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working my way through @evankanderson's book, and when writing out the example code he has listed I ran into a 404, because the URL https://knative.dev/docs/images/logo/rgb/knative-logo-rgb.png doesn't serve the Knative logo.
It took me a little sleuthing around this repo to realize that's because it's served at https://knative.dev/images/logo/rgb/knative-logo-rgb.png instead.
Since the book is in print, it's too late to fix the code listing there - So in the service if saving someone else from the same rabbit hole I just went down, I figured I'd pitch adding a redirect that makes the former URL valid.
Totally up to you all if you want to adopt it, obviously I have no particular stake in this project, I wouldn't be offended if you reject the PR :)