[RFC/PoC] Korean (ko) localization support via mkdocs-static-i18n - #6694
Draft
bluefriday wants to merge 4 commits into
Draft
[RFC/PoC] Korean (ko) localization support via mkdocs-static-i18n#6694bluefriday wants to merge 4 commits into
bluefriday wants to merge 4 commits into
Conversation
Added a README for the Knative quickstart tutorial in Korean, outlining installation and features of Knative Serving and Eventing.
Add documentation for Knative components: Serving, Eventing, and Functions.
knative-prow
Bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bluefriday The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Welcome @bluefriday! It looks like this is your first PR to knative/docs 🎉 |
knative-prow
Bot
added
the
size/L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Fixes #issue-number" or "Add description of the problem this PR solves"
Proposed Changes
mkdocs-static-i18nplugin tomkdocs.yml, usingdocs_structure: folder(mirrors
docs/ko/...alongside the existingdocs/...tree, similar to how kubernetes/website organizescontent/ko/)mkdocs-static-i18ntorequirements.txtgetting-startedpages as a sample:docs/ko/versioned/getting-started/README.mddocs/ko/versioned/getting-started/which-knative.mdHow to review
Once the Netlify deploy preview is up:
/versioned/getting-started/which-knative//ko/versioned/getting-started/which-knative/I would like to create a Korean page for Knative documentation. Please review whether this approach is feasible.