Problem
hack/install.sh lines 25–28 manually check the exit code of go run:
go run "$(dirname "$0")/../test/version_check/check_k8s_version.go"
if [[ $? -ne 0 ]]; then
echo "Kubernetes version check failed. Exiting."
exit 1
fi
set -o errexit is already active (line 19), so a non-zero exit from go run already terminates the script. The manual check is dead code that adds noise and could mislead readers into thinking set -o errexit is not active.
Proposed Fix
Remove the if [[ $? -ne 0 ]]; then … fi block and rely on set -o errexit.
Problem
hack/install.shlines 25–28 manually check the exit code ofgo run:set -o errexitis already active (line 19), so a non-zero exit fromgo runalready terminates the script. The manual check is dead code that adds noise and could mislead readers into thinkingset -o errexitis not active.Proposed Fix
Remove the
if [[ $? -ne 0 ]]; then … fiblock and rely onset -o errexit.