Skip to content

Channel status subscriber conformance test#3016

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
aliok:channel_status_subscriber_conformance_test
May 8, 2020
Merged

Channel status subscriber conformance test#3016
knative-prow-robot merged 1 commit into
knative:masterfrom
aliok:channel_status_subscriber_conformance_test

Conversation

@aliok
Copy link
Copy Markdown
Member

@aliok aliok commented Apr 20, 2020

Fixes #2993

Proposed Changes

  • Conformance tests for Channel status.subscriber field

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 20, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 20, 2020
@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Apr 20, 2020
@aliok
Copy link
Copy Markdown
Member Author

aliok commented Apr 20, 2020 •
edited
Loading

The tests fail for meta Channel (channel.messaging.knative.dev).
When we create the meta Channel it creates an InMemoryChannel by default. That InMemoryChannel has the subscribers in its status but that's not propogated to the meta Channel.

We need to either exclude the meta Channel in the tests or change the spec.

cc @lberk @matzew @aslom wdyt?

mattmoor
mattmoor reviewed Apr 20, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)

Comment thread test/conformance/helpers/channel_status_subscriber_test_helper.go
Comment thread test/conformance/helpers/channel_status_subscriber_test_helper.go Outdated
@lberk
Copy link
Copy Markdown
Member

lberk commented Apr 20, 2020

/assign

lberk
lberk reviewed Apr 20, 2020
View reviewed changes
Comment thread test/conformance/helpers/channel_status_subscriber_test_helper.go Outdated
@matzew
Copy link
Copy Markdown
Member

matzew commented Apr 20, 2020

/test pull-knative-eventing-integration-tests

@aliok aliok mentioned this pull request Apr 22, 2020
Closed
@aliok
Copy link
Copy Markdown
Member Author

aliok commented Apr 22, 2020

Created #3037 for the problem

@lberk lberk mentioned this pull request Apr 30, 2020
Closed
@lberk
Copy link
Copy Markdown
Member

lberk commented May 4, 2020

/test pull-knative-eventing-integration-tests

@aliok aliok force-pushed the channel_status_subscriber_conformance_test branch from 09e1e9c to 16ae7d4 Compare May 8, 2020 07:48
@aliok
Copy link
Copy Markdown
Member Author

aliok commented May 8, 2020

/retest

@aliok aliok force-pushed the channel_status_subscriber_conformance_test branch from 16ae7d4 to f07c1a1 Compare May 8, 2020 08:21
@aliok
Copy link
Copy Markdown
Member Author

aliok commented May 8, 2020

Rebased and it is all green.

Glad the test found the problem fixed by #3088

cc @lberk

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented May 8, 2020

Great job everybody on getting this fixed and shows the great progress on the conformance tests work 👍 🥇
/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented May 8, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2020
lberk
lberk reviewed May 8, 2020
View reviewed changes
Comment thread test/lib/creation.go
channelTypeMeta *metav1.TypeMeta,
options ...resources.SubscriptionOption,
) {
) *messagingv1alpha1.Subscription {
Copy link
Copy Markdown
Member

@lberk lberk May 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be v1beta1 subscriptions?

Copy link
Copy Markdown
Member

@lberk lberk May 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah seeing the lgtm, perhaps (if necessary) we can deal with this in a follow up

@knative-prow-robot knative-prow-robot merged commit 9ac463b into knative:master May 8, 2020
@aliok aliok deleted the channel_status_subscriber_conformance_test branch May 8, 2020 19:07
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented May 12, 2020

@aliok: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-eventing-build-tests 16ae7d4 link /test pull-knative-eventing-build-tests
pull-knative-eventing-unit-tests 16ae7d4 link /test pull-knative-eventing-unit-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lberk lberk mentioned this pull request Sep 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@chizhg chizhg Awaiting requested review from chizhg

2 more reviewers

@lberk lberk lberk left review comments

@mattmoor mattmoor mattmoor left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@lberk lberk

@vaikas vaikas

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Conformance tests for channel subscriber status requirements

7 participants

@aliok @lberk @matzew @vaikas @knative-prow-robot @mattmoor @googlebot