Added slinkydeveloper as approver#3091
Merged
Merged
Conversation
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
knative-prow-robot
added
the
size/XS
Contributor
|
/lgtm @slinkydeveloper thanks for all the great work! |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slinkydeveloper, vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From ROLES.md:
First review September 2019
12 in eventing: https://github.com/knative/eventing/pulls?q=is%3Apr+-author%3Aslinkydeveloper+reviewed-by%3Aslinkydeveloper+-label%3Asize%2FS+-label%3Asize%2FXS
9 in eventing-contrib: https://github.com/knative/eventing-contrib/pulls?q=is%3Apr+-author%3Aslinkydeveloper+reviewed-by%3Aslinkydeveloper+-label%3Asize%2FS+-label%3Asize%2FXS
Examples:
31 in eventing: https://github.com/knative/eventing/pulls?q=is%3Apr+reviewed-by%3Aslinkydeveloper
17 in eventing-contrib: https://github.com/knative/eventing-contrib/pulls?q=is%3Apr+reviewed-by%3Aslinkydeveloper
Author:
36 in eventing: https://github.com/knative/eventing/pulls?q=is%3Apr+author%3Aslinkydeveloper+
36 in eventing-contrib: https://github.com/knative/eventing-contrib/pulls?q=is%3Apr+author%3Aslinkydeveloper+
@matzew