Add note to channel spec regarding channel subscription spec#3132
Conversation
The spec.subscription fields shouldn't be set directly, rather it should be set via the subscriptions themselves and then the status should be propogated via the channel.
knative-prow-robot
added
the
size/XS
|
/cc @aliok |
|
@lberk: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/woof |
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
🤣 |
| Note: the array of subscribers MUST NOT be set directly on the channel, but | ||
| rather appended by the subscription itself. |
There was a problem hiding this comment.
This means, we need to disable direct setting on IMC and other channels in the code as well.
There was a problem hiding this comment.
@aliok -- ok I've updated, please let me know what you think!
mattmoor
left a comment
mattmoor
left a comment
There was a problem hiding this comment.
Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)
Co-authored-by: Matt Moore <mattmoor@vmware.com>
|
@Harwayne any concerns on the wording? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, lberk, vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Co-authored-by: Adam Harwayne <harwayne@google.com>
mattmoor
left a comment
mattmoor
left a comment
There was a problem hiding this comment.
Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)
mattmoor
left a comment
mattmoor
left a comment
There was a problem hiding this comment.
Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)
Co-authored-by: Matt Moore <mattmoor@vmware.com>
|
/lgtm |
8 participants
The spec.subscription fields shouldn't be set directly, rather
it should be set via the subscriptions themselves and then the status
should be propogated via the channel.
Related to:
#3050
#3051