Skip to content

Fetch broker URL at runtime for upgrade tests#3184

Merged
knative-prow-robot merged 2 commits into
knative:masterfrom
cardil:bugfix/3174-fetch-broker-url
May 23, 2020
Merged

Fetch broker URL at runtime for upgrade tests#3184
knative-prow-robot merged 2 commits into
knative:masterfrom
cardil:bugfix/3174-fetch-broker-url

Conversation

@cardil
Copy link
Copy Markdown
Contributor

@cardil cardil commented May 21, 2020 •
edited
Loading

Fixes #3174

Proposed Changes

  • Fetches the broker URL at runtime

follow up to #2388

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 21, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 21, 2020
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels May 21, 2020
@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 21, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented May 21, 2020

Hi @cardil. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cardil cardil force-pushed the bugfix/3174-fetch-broker-url branch from f702ffc to b7ba1ff Compare May 21, 2020 12:52
@cardil cardil marked this pull request as ready for review May 21, 2020 12:55
@cardil cardil changed the title [WIP] Fetch broker URL at runtime Fetch broker URL at runtime May 21, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 21, 2020
@cardil cardil changed the title Fetch broker URL at runtime Fetch broker URL at runtime for upgrade tests May 21, 2020
@devguyio
Copy link
Copy Markdown
Contributor

devguyio commented May 21, 2020

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 21, 2020
lberk
lberk reviewed May 21, 2020
View reviewed changes
Comment thread test/upgrade/prober/configuration.go Outdated
lberk
lberk reviewed May 21, 2020
View reviewed changes
Comment thread test/upgrade/prober/configuration.go Outdated
n3wscott
n3wscott reviewed May 22, 2020
View reviewed changes
Comment thread test/upgrade/prober/configuration.go
if err != nil {
return nil, err
}
broker, err := p.client.Eventing.EventingV1alpha1().Brokers(namespace).Get(brokerName, metav1.GetOptions{})
Copy link
Copy Markdown
Contributor

@n3wscott n3wscott May 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you follow-up to fetch the v1beta1 version here

Copy link
Copy Markdown
Contributor Author

@cardil cardil May 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

Copy link
Copy Markdown
Contributor Author

@cardil cardil May 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But, there are more places where alpha1 is used. Should I change all of them to beta?

Copy link
Copy Markdown
Contributor

@vaikas vaikas May 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plan is to drop the v1alpha1 in .16, so at least before then we should get rid of all the v1alpha1 ones :)

Copy link
Copy Markdown
Contributor Author

@cardil cardil May 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. I'll create issue for that, and PR.

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented May 22, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented May 22, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2020
@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented May 22, 2020

quay having a bad day looks like?

Waiting until all pods in namespace knative-monitoring are up......................................................................................................................................................

ERROR: timeout waiting for pods to come up
elasticsearch-logging-0              1/1   Running            0     5m16s
elasticsearch-logging-1              1/1   Running            0     4m30s
grafana-57bb757dd7-v575r             1/1   Running            0     5m15s
kibana-logging-669968b8d4-thnqs      1/1   Running            0     5m16s
kube-state-metrics-b6bcff8f4-cnfhg   0/1   ImagePullBackOff   0     5m16s
node-exporter-sn227                  0/2   ImagePullBackOff   0     5m15s
node-exporter-tdwrz                  0/2   ImagePullBackOff   0     5m15s
node-exporter-xj5s9                  0/2   ImagePullBackOff   0     5m15s
prometheus-system-0                  1/1   Running            0     5m14s
prometheus-system-1                  1/1   Running            0     5m14s


  - image: quay.io/coreos/kube-state-metrics:v1.7.2
    imageID: ""
    lastState: {}
    name: kube-state-metrics
    ready: false
    restartCount: 0
    started: false
    state:
      waiting:
        message: Back-off pulling image "quay.io/coreos/kube-state-metrics:v1.7.2"
        reason: ImagePullBackOff

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented May 22, 2020

/test pull-knative-eventing-integration-tests

@cardil
Copy link
Copy Markdown
Contributor Author

cardil commented May 22, 2020 •
edited
Loading

quay having a bad day looks like?

Yup. Looks like it: https://status.quay.io/incidents/xvjgfv1styzx

@cardil
Copy link
Copy Markdown
Contributor Author

cardil commented May 22, 2020

/retest

@knative-prow-robot knative-prow-robot merged commit 464bf7a into knative:master May 23, 2020
@cardil cardil deleted the bugfix/3174-fetch-broker-url branch May 23, 2020 11:59
@cardil cardil mentioned this pull request May 25, 2020
Closed
@lberk lberk mentioned this pull request Sep 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@steuhs steuhs Awaiting requested review from steuhs

3 more reviewers

@lberk lberk lberk left review comments

@vaikas vaikas vaikas left review comments

@n3wscott n3wscott n3wscott left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@vaikas vaikas

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fetch the URL from the Broker.Status instead of hardcoding it for upgrade tests

7 participants

@cardil @knative-prow-robot @devguyio @vaikas @lberk @n3wscott @googlebot