Skip to content

add flow v1 types#3354

Merged
knative-prow-robot merged 2 commits into
knative:masterfrom
lionelvillard:flow_v1
Jun 25, 2020
Merged

add flow v1 types#3354
knative-prow-robot merged 2 commits into
knative:masterfrom
lionelvillard:flow_v1

Conversation

@lionelvillard
Copy link
Copy Markdown
Contributor

@lionelvillard lionelvillard commented Jun 19, 2020

For #3335

Proposed Changes

  • Add flow v1 types (only the types!)

Release Note

Docs

Depends on #3350

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 19, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 19, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 19, 2020
@knative-prow-robot knative-prow-robot added area/test-and-release Test infrastructure, tests or release approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 19, 2020
@lionelvillard lionelvillard marked this pull request as draft June 19, 2020 19:03
@lionelvillard lionelvillard changed the title WIP: add flow v1 types add flow v1 types Jun 25, 2020
@lionelvillard lionelvillard marked this pull request as ready for review June 25, 2020 18:55
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2020
@lionelvillard
Copy link
Copy Markdown
Contributor Author

lionelvillard commented Jun 25, 2020

@vaikas @nlopezgi

nlopezgi
nlopezgi reviewed Jun 25, 2020
View reviewed changes
Comment thread pkg/apis/flows/v1/parallel_types.go Outdated
)

// +genclient
// +genreconciler:krshapedlogic=true
Copy link
Copy Markdown
Contributor

@nlopezgi nlopezgi Jun 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

krshapedlogic=true is now the default and can be removed

Comment thread pkg/apis/flows/v1/sequence_types.go Outdated
)

// +genclient
// +genreconciler:krshapedlogic=true
Copy link
Copy Markdown
Contributor

@nlopezgi nlopezgi Jun 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above, remove krshapedlogic=true

@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Jun 25, 2020

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/flows/v1/parallel_conversion.go Do not exist 100.0%
pkg/apis/flows/v1/parallel_defaults.go Do not exist 100.0%
pkg/apis/flows/v1/parallel_lifecycle.go Do not exist 96.5%
pkg/apis/flows/v1/parallel_types.go Do not exist 100.0%
pkg/apis/flows/v1/parallel_validation.go Do not exist 0.0%
pkg/apis/flows/v1/register.go Do not exist 0.0%
pkg/apis/flows/v1/sequence_conversion.go Do not exist 100.0%
pkg/apis/flows/v1/sequence_defaults.go Do not exist 100.0%
pkg/apis/flows/v1/sequence_lifecycle.go Do not exist 95.5%
pkg/apis/flows/v1/sequence_types.go Do not exist 100.0%
pkg/apis/flows/v1/sequence_validation.go Do not exist 0.0%

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 25, 2020

@lionelvillard: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-eventing-go-coverage be22d0a link /test pull-knative-eventing-go-coverage

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nlopezgi
Copy link
Copy Markdown
Contributor

nlopezgi commented Jun 25, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2020
@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Jun 25, 2020

/lgtm
/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 25, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [lionelvillard,vaikas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit ffcc29a into knative:master Jun 25, 2020
lberk pushed a commit to lberk/eventing that referenced this pull request Jun 26, 2020
@lionelvillard @lberk
add flow v1 types (knative#3354)
992e2c7 
* add flow v1 types

* remove krshapedlogic=true
@lionelvillard lionelvillard mentioned this pull request Jun 30, 2020
Closed
8 tasks
@lionelvillard lionelvillard deleted the flow_v1 branch September 3, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nachocano nachocano Awaiting requested review from nachocano

@yt3liu yt3liu Awaiting requested review from yt3liu

1 more reviewer

@nlopezgi nlopezgi nlopezgi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@nlopezgi nlopezgi

@vaikas vaikas

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lionelvillard @knative-metrics-robot @knative-prow-robot @nlopezgi @vaikas @googlebot