Skip to content

Eventing conversion v1 <> v1beta1#3402

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
aliok:eventing_conversion
Jun 24, 2020
Merged

Eventing conversion v1 <> v1beta1#3402
knative-prow-robot merged 1 commit into
knative:masterfrom
aliok:eventing_conversion

Conversation

@aliok
Copy link
Copy Markdown
Member

@aliok aliok commented Jun 24, 2020

Part of #3337

Proposed Changes

  • Conversion from/to v1 <--> v1beta1 types
  • v1->v1beta1->v1 and v1beta1->v1->v1beta1 tests

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 24, 2020
@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 24, 2020
Copy link
Copy Markdown
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v wire_gen.go)

Copy link
Copy Markdown
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v wire_gen.go)

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 24, 2020
@aliok aliok force-pushed the eventing_conversion branch from d6f3a34 to 96ad66a Compare June 24, 2020 16:30
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 24, 2020
@aliok aliok changed the title [WIP] Eventing conversion v1 <> v1beta1 Eventing conversion v1 <> v1beta1 Jun 24, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2020
@aliok
Copy link
Copy Markdown
Member Author

aliok commented Jun 24, 2020

/assign @vaikas
/hold

Let's hold this one until @vaikas reviews it as we're working on this together

Copy link
Copy Markdown
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v wire_gen.go)

Comment thread pkg/apis/eventing/v1beta1/broker_conversion.go
Comment thread pkg/apis/eventing/v1beta1/broker_conversion_test.go
Comment thread pkg/apis/eventing/v1beta1/trigger_conversion.go
Comment thread pkg/apis/eventing/v1beta1/trigger_conversion_test.go
@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2020
@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/eventing/v1beta1/broker_conversion.go 77.8% 90.9% 13.1
pkg/apis/eventing/v1beta1/trigger_conversion.go 72.7% 100.0% 27.3

@aliok
Copy link
Copy Markdown
Member Author

aliok commented Jun 24, 2020

/retest

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Jun 24, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2020
@pierDipi
Copy link
Copy Markdown
Member

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2020
@knative-prow-robot knative-prow-robot merged commit 2330781 into knative:master Jun 24, 2020
lberk pushed a commit to lberk/eventing that referenced this pull request Jun 26, 2020
@aliok aliok deleted the eventing_conversion branch April 28, 2021 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants