Skip to content

use eventing as label instead of serving#3445

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
matzew:typo
Jun 30, 2020
Merged

use eventing as label instead of serving#3445
knative-prow-robot merged 1 commit into
knative:masterfrom
matzew:typo

Conversation

@matzew
Copy link
Copy Markdown
Member

@matzew matzew commented Jun 30, 2020

Proposed Changes

  • use eventing as label instead of serving

Release Note


Docs

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 30, 2020
@matzew matzew requested a review from vaikas June 30, 2020 12:58
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 30, 2020
@matzew matzew requested review from lionelvillard and removed request for liu-cong and slinkydeveloper June 30, 2020 12:58
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2020
Copy link
Copy Markdown
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-test-reporter-robot
Copy link
Copy Markdown

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-integration-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

test/conformance.TestBrokerTracing
test/conformance.TestChannelTracingWithReply
test/conformance.TestBrokerTracing/Channel-messaging.knative.dev/v1beta1
test/conformance.TestChannelTracingWithReply/Channel-messaging.knative.dev/v1beta1
test/conformance.TestChannelTracingWithReply/InMemoryChannel-messaging.knative.dev/v1beta1
test/conformance.TestBrokerTracing/InMemoryChannel-messaging.knative.dev/v1beta1

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 30, 2020 via email

@slinkydeveloper
Copy link
Copy Markdown
Contributor

@knative-prow-robot knative-prow-robot merged commit 5bc82ad into knative:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants